Closed Bug 387747 Opened 13 years ago Closed 11 years ago

add a star column to bookmarked items in the organizer center pane

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set

Tracking

()

VERIFIED WONTFIX

People

(Reporter: dietrich, Assigned: christineyen+bugs)

References

()

Details

(Whiteboard: [places-ui])

Attachments

(1 file)

see the bug URL for mockups and notes.

is it interactive? one idea alex had was that clicking a starred item would bring up a delete prompt.
Assignee: nobody → cyen
Attached patch v0.1Splinter Review
Reflects the starred status of the page, made toggleable/effective by (but not dependent on) Mano's patch for bug 385266.

Current issues:

- Column index is persisted ("persist=' .... ordinal ...'") and so unless you apply this patch and experiment with a fresh profile, the star column will appear at the end.

- I wasn't entirely sure what to do with Livemarks - at this point, you can star an rss feed and the column will check the livemark container's feed URI. Livemark items don't get a star icon at all, nor do folders and separators.

- Should I be using the CSS attribute Mano added to browser.css under #star-icon / #star-icon[starred="true"]? What's the best way to access a remote src instead of hard-coding in the url to that image?
via irc:

<Mano>: well, you'll have to wait for the new finder to land first
<Mano>: it changes the way we set the columns
<Mano>: i think you only want this column for history queries anyway
Depends on: 387746
Whiteboard: [swag: 1d]
Target Milestone: --- → Firefox 3 M8
Whiteboard: [swag: 1d] → [swag: 1d] [places-ui]
Blocks: 395257
Target Milestone: Firefox 3 M8 → Firefox 3 M9
Target Milestone: Firefox 3 M9 → Firefox 3 M10
Target Milestone: Firefox 3 M10 → Firefox 3 M11
note: implementing a star column could be unified with bug 405276
Target Milestone: Firefox 3 beta3 → ---
(In reply to comment #2)
> via irc:
> 
> <Mano>: well, you'll have to wait for the new finder to land first

Anyone knows which bug this is? It should be block this one.
This was originally my idea, but I've changed my mind.  I'm going to resolve this to wontfix since the UI would be redundant, visually a little noisy, and increase chance of accidental deletion.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Thats correct. Each bookmark listed within a folder will have the star icon displayed. Removing it also removes the bookmark. It doesn't make sense to display it there. Thanks Alex.
Status: RESOLVED → VERIFIED
Whiteboard: [swag: 1d] [places-ui] → [places-ui]
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.