387840 - Thunderbird runs safe-browsing

Status: RESOLVED WONTFIX

(Thunderbird :: Build Config, defect)

Description

[Daniel Veditz [:dveditz]]

Thunderbird includes the toolkit urlclassifier service, and it's even causing the #7 topcrash in 2.0.0.4!

We need to stick --disable-safe-browsing into the default tbird config to turn this off, otherwise we're taking the startup hit, keeping extra filehandles open (urlclassifier2.sqlite), and even risking extra crashes.

If we upgrade the Tb3 anti-phishing to include real data rather than just heuristics then that can easily be changed.

see bug 321034 comment 23

Comment 1

[Daniel Veditz [:dveditz]]

make that bug 321024 comment 23

Since the urlclassifier doesn't do much good without front-end support acting on the data it probably should be default-disabled in toolkit rather than default-enabled. Otherwise anyone making a xulrunner app needs to know to turn it off, and Sunbird, and maybe also Firefox-based browsers like Flock and Netscape (dunno if they use the anti-phishing stuff or not, or if they need formal agreements w/Google to have all their users hit the google-hosted service).

Comment 2

[Tony Chang (Google)]

I think it's safe to keep it on by default. It adds a bit of code bloat, but that's it.  The UrlClassifier service doesn't do anything unless you grab an instance of it.

Also, I think Flock does use anti-phishing stuff, however, they only get some of the data (basically, the same protection you get from the api: http://code.google.com/apis/safebrowsing/ ).

Comment 3

[Daniel Veditz [:dveditz]]

Turns out Tbird definitely intends to use this code on the branch. I thought that feature had been cut, but was wrong -- there is front-end support for it.

Comment 4

[Daniel Veditz [:dveditz]]

oh, and my concerns in comment 1 were misplaced, it _is_ disabled by default and explicitly enabled in configure.in for the browser and mail projects.