Closed Bug 387884 Opened 12 years ago Closed 12 years ago

Use of assignment instead of comparison in assertion

Categories

(Core :: Web Painting, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
The checkin for bug 324963 introduced an assertion that assigns rather than compares.
Flags: in-testsuite-
Attachment #272010 - Flags: superreview?(roc)
Attachment #272010 - Flags: review?(roc)
Attachment #272010 - Flags: superreview?(roc)
Attachment #272010 - Flags: superreview+
Attachment #272010 - Flags: review?(roc)
Attachment #272010 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 272010 [details] [diff] [review]
patch

This is a DEBUG-only patch that I accidentally backed out last week and want to reland -- it should be relanded so that DEBUG builds don't potentially differ from non-DEBUG.  No risk to non-DEBUG.
Attachment #272010 - Flags: approval1.9?
Comment on attachment 272010 [details] [diff] [review]
patch

Never mind.  Approval probably isn't needed for DEBUG-only code.
Attachment #272010 - Flags: approval1.9?
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.