387999 - theme preview image is squished when using splitter

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[mcdavis941 (sporadically reading bugmail)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007070804 Minefield/3.0a7pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007070804 Minefield/3.0a7pre

With the themes view of the Add-ons Manager, if you move the splitter (between the list of themes and the theme preview) to the right, it squishes the theme preview image along the x axis.  

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: screenshot of the problem

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Confirming, on Branch the image does not resize and a scrollbar appears
on trunk it resize horizontally, sometimes a scrollbar appears too, while it should resize mantaining ratio

Comment 3

[Robert Strong (they/them - no direct email)]

note: bug 267831 may also be related in that this is most likely due to a core or widget change

Comment 4

[u294409]

I can confirm on Linux.

Comment 5

[Louise]

confirmed on Mac OS X 10.5.2
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008042317 Minefield/3.0pre ID:2008042317

Comment 6

[mcdavis941 (sporadically reading bugmail)]

Attachment: screenshot showing still happening on winXP with 20080424 nightly

Comment 7

[mcdavis941 (sporadically reading bugmail)]

Requesting blocking because Bug 428677 blocked also.

Comment 8

[u294409]

change os to all.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

We just need to set a size for preview images, and then lock the right hand side to that minwidth. Doesn't block, but easy fix IMO.

Comment 10

[Alfred Kayser]

Easier would be to make the theme preview image box scrollable, so that the image will not be squished...

Comment 11

[Nochum Sossonko [:Natch]]

It's a little tricky here, b/c the themePreviewArea box has some wierd styling (width:0px) and it won't seem to behave when it's changed, ie if you give it a min-width the splitter will just snap to the right when that min-width is reached, and if you give the deck only a min-width it'll maintain it's width and just produce scrollbars when the splitter passes that min-width, eventually just completely closing...

Any further ideas?

Comment 12

[Alfred Kayser]

Remove that styling and replace by a more normal scrollable view...

Comment 13

[Dave Townsend [:mossop]]

Fixed by bug 423469

Comment 14

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081014 Minefield/3.1b2pre. Also verified on Windows Vista.