Closed Bug 388064 Opened 13 years ago Closed 13 years ago

Change active popup code from bug 324963

Categories

(Core :: XUL, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

Attachments

(1 file)

The XULPopupManager now keeps track of open popups, so the list stored in the PresContext added in bug 324963 isn't needed any more. Another advantage is that it keeps track of all popups, not just the menu type ones.

This change is needed otherwise I can't create tests which simulate mouse events over a popup properly, as only some types of menus are in the list.
Flags: blocking1.9?
Attachment #272209 - Flags: superreview?(roc)
Attachment #272209 - Flags: review?(roc)
+#include "nsIPrivateDOMEvent.h"

What's this for?

+        const nsTArray<nsIFrame*>& popups = pm->GetOpenPopups();

This should be just an nsTArray<nsIFrame*>, I guess.
Comment on attachment 272209 [details] [diff] [review]
adjust the popup coordinate checking code

with those addressed, this is really good!
Attachment #272209 - Flags: superreview?(roc)
Attachment #272209 - Flags: superreview+
Attachment #272209 - Flags: review?(roc)
Attachment #272209 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Depends on: 388359
Depends on: 388761
Flags: blocking1.9?
Popup tests needed this, so this is tested
Flags: in-testsuite+
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.