388064 - Change active popup code from bug 324963

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Neil Deakin]

Attachment: adjust the popup coordinate checking code

The XULPopupManager now keeps track of open popups, so the list stored in the PresContext added in bug 324963 isn't needed any more. Another advantage is that it keeps track of all popups, not just the menu type ones.

This change is needed otherwise I can't create tests which simulate mouse events over a popup properly, as only some types of menus are in the list.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+#include "nsIPrivateDOMEvent.h"

What's this for?

+        const nsTArray<nsIFrame*>& popups = pm->GetOpenPopups();

This should be just an nsTArray<nsIFrame*>, I guess.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 272209 [details] [diff] [review]
adjust the popup coordinate checking code

with those addressed, this is really good!

Comment 3

[Neil Deakin]

Popup tests needed this, so this is tested