Closed Bug 388093 Opened 12 years ago Closed 12 years ago

CNavDTD misuses PRBool as an integer

Categories

(Core :: HTML: Parser, defect, minor)

x86
Linux
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: mrbkap, Assigned: mrbkap)

Details

Attachments

(1 file)

There are a couple of places where CNavDTD uses a PRBool with value -1 to mean "unknown state." taras's tool in bug 266048 tried to deal with them, but failed, since it simply coerces the -1 assignments to booleans, which isn't what we want. I'm filing this bug to fix those cases manually.
Attached patch FixSplinter Review
This is fairly straightforward, I think.
Attachment #272255 - Flags: superreview?(jst)
Attachment #272255 - Flags: review?(jst)
Attachment #272255 - Flags: superreview?(jst)
Attachment #272255 - Flags: superreview+
Attachment #272255 - Flags: review?(jst)
Attachment #272255 - Flags: review+
Fix checked into trunk.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.