388101 - nsMsgDatabase leaks a mork factory

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Scott MacGregor]

the static method: nsMsgDatabase::GetMDBFactory
has a reference to a nsIMdbFactory which never gets released.


http://mxr.mozilla.org/mozilla/source/mailnews/db/msgdb/src/nsMsgDatabase.cpp#976

Comment 1

[Scott MacGregor]

I think nsAddrDatabase suffers from the same leak.

Comment 2

[Scott MacGregor]

Attachment: [checked in]one way to fix this

This is one way we could fix this leak. nsIMdbFactoryFactory already caches the mork factory for us. See:

NS_IMETHODIMP nsMorkFactoryFactory::GetMdbFactory(nsIMdbFactory **aFactory)
{
  if (!gMDBFactory)
    gMDBFactory = MakeMdbFactory();
  *aFactory = gMDBFactory;
  NS_IF_ADDREF(gMDBFactory);
  return (gMDBFactory) ? NS_OK : NS_ERROR_OUT_OF_MEMORY;
}

So use a nsCOMPtr and let each database object have its own ref to the factory singleton.

Comment 3

[Scott MacGregor]

Attachment: same fix for the address book data source