copy and paste from bookmarks into notepad.exe, and we lose newlines

VERIFIED FIXED in Firefox 3 alpha8

Status

()

VERIFIED FIXED
11 years ago
9 years ago

People

(Reporter: moco, Assigned: christineyen+bugs)

Tracking

Trunk
Firefox 3 alpha8
x86
Windows XP
Points:
---
Bug Flags:
in-litmus +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

copy and paste from bookmarks into notepad.exe, and we lose newlines

In util.js, after the fix for bug #378558, our text/unicode contains \n.

Something like:

#ifdef XP_MACOSX
const NEWLINE= "\n";
#else
const NEWLINE = "\r\n";
#endif

and then use NEWLINE in utils.js.

I wonder where else generate text/unicode for the clipboard on copy?
(Assignee)

Comment 1

11 years ago
Created attachment 275838 [details] [diff] [review]
patch
Assignee: nobody → christineyen+bugs
Status: NEW → ASSIGNED
Attachment #275838 - Flags: review?(sspitzer)
Created attachment 275894 [details] [diff] [review]
updated patch

I reviewed and tested your patch, and it only fixed part of the problem.  the other part is that we are missing some line separators when generating unicode (see attached patch), based on your patch.
Attachment #275838 - Attachment is obsolete: true
Attachment #275894 - Flags: review?(christineyen+bugs)
Attachment #275838 - Flags: review?(sspitzer)
Comment on attachment 275894 [details] [diff] [review]
updated patch

clearing review, per cyen's comments over irc.  she's working on a better patch.
Attachment #275894 - Flags: review?(christineyen+bugs)
(Assignee)

Comment 4

11 years ago
Created attachment 275895 [details] [diff] [review]
updated patch again

replacing "suffix" in controller.js with NEWLINE instead of \n, instead of adding NEWLINEs to whatever is returned from gatherDataText in utils.js
Attachment #275894 - Attachment is obsolete: true
Attachment #275895 - Flags: review?(sspitzer)
Created attachment 275899 [details] [diff] [review]
updated patch
Attachment #275895 - Attachment is obsolete: true
Attachment #275895 - Flags: review?(sspitzer)
fixed.

Checking in controller.js;
/cvsroot/mozilla/browser/components/places/content/controller.js,v  <--  control
ler.js
new revision: 1.176; previous revision: 1.175
done
Checking in utils.js;
/cvsroot/mozilla/browser/components/places/content/utils.js,v  <--  utils.js
new revision: 1.54; previous revision: 1.53
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M8
Comment on attachment 275899 [details] [diff] [review]
updated patch

r=sspitzer (this is christine's previous patch + one minor change)
Attachment #275899 - Flags: review+
Flags: in-litmus?
Litmus Triage Team: Adding Al and tracy to this bug for Litmus coverage.
verified FIXED on trunk build:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090316 Minefield/3.2a1pre ID:20090316044350

Test cases were added to litmus for regression testing in 3.x test runs.


For 3.0,
https://litmus.mozilla.org/show_test.cgi?id=7607

For 3.1,
https://litmus.mozilla.org/show_test.cgi?id=7608
Status: RESOLVED → VERIFIED
Flags: in-litmus? → in-litmus+
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.