Closed Bug 388115 Opened 14 years ago Closed 14 years ago

[FIX]nsJSContext::Deserialize doesn't propagate errors

Categories

(Core :: DOM: Core & HTML, defect)

x86
Linux
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Attached patch FixSplinter Review
I'm asserting because this thing blithely ignores script deserialization failures and goes on to set null script objects in things which shouldn't get those.  Been a problem ever since it landed.
Attachment #272277 - Flags: superreview?(brendan)
Attachment #272277 - Flags: review?(jst)
Attachment #272277 - Flags: review?(jst) → review+
Comment on attachment 272277 [details] [diff] [review]
Fix

Should mhammond be cc'ed?

/be
Attachment #272277 - Flags: superreview?(brendan) → superreview+
> Should mhammond be cc'ed?

Probably...
Fixed.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.