[FIX]nsJSContext::Deserialize doesn't propagate errors

RESOLVED FIXED in mozilla1.9alpha8

Status

()

--
major
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

unspecified
mozilla1.9alpha8
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 272277 [details] [diff] [review]
Fix

I'm asserting because this thing blithely ignores script deserialization failures and goes on to set null script objects in things which shouldn't get those.  Been a problem ever since it landed.
Attachment #272277 - Flags: superreview?(brendan)
Attachment #272277 - Flags: review?(jst)

Updated

11 years ago
Attachment #272277 - Flags: review?(jst) → review+
Comment on attachment 272277 [details] [diff] [review]
Fix

Should mhammond be cc'ed?

/be
Attachment #272277 - Flags: superreview?(brendan) → superreview+
(Assignee)

Comment 2

11 years ago
> Should mhammond be cc'ed?

Probably...
(Assignee)

Comment 3

11 years ago
Fixed.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.