Closed Bug 388190 Opened 13 years ago Closed 13 years ago

XPCOMUtils spews uuids when registering components

Categories

(Core :: XPConnect, defect, trivial)

x86
macOS
defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: Dolske, Assigned: Dolske)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch for review, v.1 (obsolete) — Splinter Review
This is really ugly to see on the console when components are getting registered:

*** loading XPCOMUtils
*** registering storage-Legacy.js: [ {e09e4ca6-276b-4bb4-8b71-0635a3a2a007} ]
*** registering nsSearchSuggestions.js: [ {aa892eb4-ffbf-477d-9f9a-06c995ae9f27} ]
*** Deferring registration of sample JS components
*** registering nsMicrosummaryService.js: [ {460a9792-b154-4f26-a922-0f653e2c8f91} ]
*** registering nsLoginManagerPrompter.js: [ {447fc780-1d28-412a-91a1-466d48129c65} ]
*** registering nsLoginManager.js: [ {cb9e0de8-3598-4ed7-857b-827f011ad5d8} ]
*** registering nsLoginInfo.js: [ {0f2f347c-1e4f-40cc-8efd-792dea70a85e} ]
*** registering nsContentPrefService.js: [ {e6a3f533-4ffa-4615-8eb4-d4e72d883fa7} {8df290ae-dcaa-4c11-98a5-2429a4dc97bb} ]
*** registering FeedProcessor.js: [ {26acb1f0-28fc-43bc-867a-a46aabc85dd4} {072a5c3d-30c6-4f07-b87f-9f63d51403f2} {5d0cfa97-69dd-4e5e-ac84-f253162e8f9a} {8e4444ff-8e99-4bdd-aa7f-fb3c1c77319f} {b992ddcd-3899-4320-9909-924b3e72c922} {414af362-9ad8-4296-898e-62247f25a20e} {95c963b7-20b2-11db-92f6-001422106990} ]

Showing the component class names would be much nicer. The normal XPCOM glue registration doesn't print the individual component names at all, but I suppose XPCOMUtils is new enough that a little extra output is a good idea for now.

This patch matches what unregisterSelf already does.
Attachment #272367 - Flags: superreview?(benjamin)
Attachment #272367 - Flags: review?(sayrer)
Assignee: nobody → dolske
Comment on attachment 272367 [details] [diff] [review]
Patch for review, v.1

I thought I already reviewed a patch that makes this log conditionally, but showing the name seems like an improvement in any case.
Attachment #272367 - Flags: review?(sayrer) → review+
Add field separators and smart formatting. Since there are consumers of this feature now, printing "*** loading XPCOMUtils" all the time isn't really useful.

Current output:

*** registering storage-Legacy.js: [ LoginManagerStorage_legacy ]
*** registering nsSearchSuggestions.js: [ Remote Search Suggestions ]
*** Deferring registration of sample JS components
*** registering nsMicrosummaryService.js: [ Microsummary Service ]
*** registering nsLoginManagerPrompter.js: [ LoginManagerPromptFactory ]
*** registering nsLoginManager.js: [ LoginManager ]
*** registering nsLoginInfo.js: [ LoginInfo ]
*** registering nsContentPrefService.js: [ Content Pref Service, Hostname Grouper ]
*** registering FeedProcessor.js: [ Feed Processor, Feed Result, Feed, Feed Entry, Feed Text Construct, Feed Generator, Feed Person ]
Attachment #272367 - Attachment is obsolete: true
Attachment #272368 - Flags: superreview?(benjamin)
Attachment #272368 - Flags: review?(sayrer)
Attachment #272367 - Flags: superreview?(benjamin)
Attachment #272368 - Flags: review?(sayrer) → review+
Attachment #272368 - Flags: superreview?(benjamin) → superreview+
Checking in js/src/xpconnect/loader/XPCOMUtils.jsm;
/cvsroot/mozilla/js/src/xpconnect/loader/XPCOMUtils.jsm,v  <--  XPCOMUtils.jsm
new revision: 1.5; previous revision: 1.4
done
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.