38820 - javascript console text not wrapping

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[Jae Gangemi]

the javascript console isn't wrapping text properly. instead, it's writing on
top of the last portion of text that is already written, and just making it
jumbled.

noticed this will exploring the url bar enter bug.

i'll post a picture in a sec

Comment 1

[Jae Gangemi]

Attachment: javascript console capture

Comment 2

[sairuh (rarely reading bugmail)]

paw, d'you know the appropriate owner/component for this? cc'ing mccabe in case
this is his stuff...

Comment 3

[Paul Wyskoczka]

Mike is working on the js console.

Comment 4

[Mike McCabe]

Assigning to myself.  I've seen this intermittently for a while, and I have no
idea what's causing it - any xul wizards present?

Comment 5

[sairuh (rarely reading bugmail)]

cc'ing ben in case he can provide input...

Comment 6

[Mike McCabe]

Layout mojo.  This currently WORKSFORME.  Still broken for anyone with recent
builds?  Otherwise, I'll close it.

Comment 7

[Paul Wyskoczka]

Sarah, this looks like this is fixed.  Do you agree?

Comment 8

[Jae Gangemi]

i'm not noticing it any longer - looks like it can be closed.

should it be "marked" with anything in case it resurfaces?

Comment 9

[Paul Wyskoczka]

Mike could you mark the bug Resolved/Worksforme - Thanks
Jae, I don't think we need to do anything special here.  If it resurfaces again, 
we can just reopen. 

Comment 10

[Mike McCabe]

Marking WORKSFORME, thanks to whatever layout magic occured between now and two
weeks ago.

Comment 11

[Paul Wyskoczka]

Verified in build 2000051820

Comment 12

[WD]

*** Bug 41914 has been marked as a duplicate of this bug. ***

Comment 13

[WD]

I don't think this bug was ever totally fixed.
Check bug 41914 for directions on how to re-create.
(I used http://www.projectcool.com , and re-loaded several times to fill the
javascript console)

Re-opening

Comment 14

[Jae Gangemi]

it looks like it is resurfacing b/c we've got a WORKSFORME in the comments - so
something must have broken the 'magic' fix again.

Comment 15

[Eric Hodel]

Using the javascript console on 2000071810 I see that the text runs on one long
line that is only viewable by increasing the width of the window.  I would
prefer this bug not be closed until the contents of the message wrap or scroll
so I can see the whole thing.

Comment 16

[Mike McCabe]

Ben, any hints?

Comment 17

[sairuh (rarely reading bugmail)]

*** Bug 46345 has been marked as a duplicate of this bug. ***

Comment 18

[Matthias Kerkhoff]

I would like to illustrate the "no-line-breaking-in-the-console" error a bit. I 
just had the problem to run into an error, which has been too large to view in 
the console. There is a maximum width for windows (on windows) that is equal to  
the desktop width. If you take a look at the screenshot, you will see that just 
the most important information (the line number, where the error occured) is not 
readable/hidden/clipped.

Comment 19

[Matthias Kerkhoff]

Attachment: screenshot

Comment 20

[Mike McCabe]

[SPAM] Marking milestone 'future' as part of nsbeta3 triage.

Comment 21

[Eric Hodel]

I have fixed this bug on my local copy, and its really easy.  You just need to
add the following style to global/skin/console.css

white-space: normal;

this will allow the line to wrap white-space because by default a <treecell> has
white-space: nowrap; set (global/skin/tree.css)

Comment 22

[sairuh (rarely reading bugmail)]

eric, would you like to submit that as a patch for review and ultimate checkin?
that'd be tres cool!

se

Comment 23

[Decklin Foster]

Attachment: drbrain's patch

Comment 24

[Decklin Foster]

Attachment: same patch, but with rules for classic this time. ignore the other one.

Comment 25

[sairuh (rarely reading bugmail)]

could someone review this patch? thx!

Comment 26

[Mike McCabe]

r=mccabe, looks great.  Thanks so much for finding this!  Now I just have to
figure out the proper steps to get it checked in...

Comment 27

[Mike McCabe]

Removing helpwanted, adding nsbeta3.  It's a good, simple patch, and I'd like to
get it in.

Comment 28

[Blake Ross]

The patch is by a Mozilla contributor, so nsbeta3+ isn't necessary.  Just need 
reviewer from the module owner (ohhh Don?), and approval/super-review from 
someone at http://www.mozilla.org/hacking/reviewers.html.  When you email one 
of the approvers for approval, cc [e-mail].

See, it's easy. :-)

Comment 29

[Mike McCabe]

Nominating for rtm.

Tiny fix limited to .css style files makes the JS console usable.

Comment 30

[Mike McCabe]

Bumping priority to P2.

This change makes the JS Console usable, especially on small screens.  Without
this low-risk fix, we're very likely to spin many more cycles on this problem on
QA response time.

Comment 31

[Ben Goodger (use ben at mozilla dot org for email)]

a=ben. 

Comment 32

[Patrick C. Beard]

Low-risk, and should reduce future QA load.

Comment 33

[Phil Peterson]

PDT marking [rtm++]

Comment 34

[Mike McCabe]

Fix checked in to branch and trunk.

Many thanks for all the help.

Comment 35

[blanca]

Verified in build 2000103104-mn6 & 200103104-Mtrunk on Windows NT and 95
Verified in build 2000110104-mn6 & 200110104-Mtrunk on Windows 98

Comment 36

[blanca]

Verified in build 2000-11-04-09-mn6 on Windows NT

Comment 37

[Paul Wyskoczka]

Verified on Mac in build 11032000-mn6
Verified on Linux in build 11032000-mnt

Still needs to be verified on the trunk for Mac and Linux

Comment 38

[Boris Zbarsky [:bzbarsky]]

Verified in Linux trunk build 2000110521

Comment 39

[Asa Dotzler [:asa]]

Verified on mac mozilla trunk build 110604 on Mac OS9.  Setting bug status to
Verified and removing vtrunk keyword.