388209 - bookmarks menu dnd indicator not visible if I want to drop an item before a separator

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P4)

Description

[Daniel.S]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071405 Minefield/3.0a7pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071405 Minefield/3.0a7pre

In the bookmarks menu, when I want to drop an item before a separator, the drag and drop indicator isn't shown. However, it is possible to drop the before the separator.

Reproducible: Always

Comment 1

[Ria Klaassen (not reading all bugmail)]

WFM with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071422 Minefield/3.0a7pre

Comment 2

[Daniel.S]

Strange, it was confirmed by
http://forums.mozillazine.org/viewtopic.php?p=2966811#2966811

But that doesn't matter now. As of
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071504 Minefield/3.0a7pre ID:2007071504
there's no indicator shown in any case which is probably a regression from bug 243078 or bug 337771.

Comment 3

[Ria Klaassen (not reading all bugmail)]

I was talking about the drag&drop cursor. Confirmed that there is no line drawn above a separator.

Comment 4

[Christine Yen]

WFM on Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/2007071610 Minefield/3.0a7pre

Comment 5

[Mike Connor [:mconnor]]

Please renominate if this is still being seen, with platform information.

Comment 6

[Daniel.S]

(In reply to comment #5)
> Please renominate if this is still being seen, with platform information.

The black line that indicates where an item is dropped doesn't appear at all in the latest nightly (actually since the build I mentioned in comment #2).

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072304 Minefield/3.0a7pre ID:2007072304
Of course, I tested this with a new profile.

Comment 7

[Peter van der Woude [:Peter6]]

I filed Bug 389290 for the completely missing dropmarker.
This bug regressed before that though.

Comment 8

[Peter van der Woude [:Peter6]]

Just to make sure everyone understands this bug

....
bookmark_1
---------- (separator)
bookmark_2

in the bookmarks menu drag bookmark_2 between the separator and bookmark_1

result:
the dropmarker (line) does not appear.

Because of Bug 389290 you'll need 20070714 nightly or before to see it.

Comment 9

[Tracy Walker [:tracy]]

I don't see a drop indicator in the bookmarks menus no matter where I mouse. Not just around separators.

Comment 10

[Peter van der Woude [:Peter6]]

(In reply to comment #9)
> I don't see a drop indicator in the bookmarks menus no matter where I mouse.
> Not just around separators.
> 
that's Bug 389290

Comment 11

[Peter van der Woude [:Peter6]]

right....
this initially regressed with the reintroduction of places which broke all dropmarks in the bookmarks menu
20070518_2135_N_firefox-3.0a5pre.en-US.win32 (first places build)

it was partially unregressed between

20070520_1339_firefox-3.0a5pre.en-US.win32 and
20070520_2107_firefox-3.0a5pre.en-US.win32 (sorry I have no other builds)

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-05-20+13%3A39%3A00&maxdate=1179720419&cvsroot=%2Fcvsroot

when the dropmarkers came back, except for the problem described in this bug.

looking at the range, Bug 381281 could have been not fully fixing the problem.
Reopening that one seems a bit pointless though.

Comment 12

[Bill Gianopoulos [:WG9s]]

I do not see this issue at all with:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008021504 Minefield/3.0b4pre ID:2008021504

Comment 13

[Daniel.S]

What do you mean Bill? I can't see a dropmarker at all (that's why this bug depends on Bug 389290) in Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008021504
Minefield/3.0b4pre ID:2008021504

Hopefully the patch in Bug 389290 fixes this one as well.

Comment 14

[Bill Gianopoulos [:WG9s]]

OH. never mind.  It says bookmarks menu.  Thought you were talking about in the places organizer.

Comment 15

[pal-moz]

seems to be fixed with/by Bug 389290

Comment 16

[(mostly gone) XtC4UaLL [:xtc4uall]]

yep, confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022204 Firefox/3.0.0.0 ID:2008022204

Comment 17

[Daniel.S]

Yes, the problem I reported here is fixed. Thanks :)

Comment 18

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre)
Gecko/2008022704 Minefield/3.0b4pre

Comment 19

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv