388223 - unit test CLOBBER support doesn't seem to work

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

kherron has noticed that the unit test buildbots (at least the Windows ones) don't seem to be observing changes to the CLOBBER files (on HEAD). It looks to me like this is because they scan cvsco.log for the line "U mozilla/tools/tinderbox-configs/firefox/<platform>/CLOBBER", but mozilla/tools/tinderbox-configs isn't in the default checkout for MOZ_CO_PROJECT=browser. They'd need to explicitly |cvs up| the CLOBBER file and check the output of that (look for "U" or "P", I guess).

Comment 1

[Adam Guthrie]

They also need to use the "test_unit" CVS branch if they're not doing that already.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Ah, right. And it looks like |cvs up| won't work if that directory hasn't been checked out, even if you use |cvs up -d|.

Given that, it looks to me like running |cvs co -rtest_unit mozilla/tools/tinderbox-configs/firefox/<platform>/CLOBBER| from /mozilla and checking the output for "^[U|P]" would work OK.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This is pretty important -- we keep getting into the situation of needing to clobber the unit test boxes, and if rob's not around, noone can do it.

Comment 5

[Rob Campbell [:rc] (:robcee)]

raising priority on this. Will get it fixed by this weekend.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Attachment: 388223.diff

sorry for the delay. This should be fixed now. Updated the mozconfig files to pull mozilla/tools/tinderbox-configs. It got missed somehow during some configuration file shuffling.

Comment 7

[Rob Campbell [:rc] (:robcee)]

Attachment: 388223.diff

the python clobber script was pretty rough. It should be working now.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Maybe there's something I'm missing, but that doesn't seem to actually solve the problem - you're still looking for the line in cvsco.log, and as far as I know the CLOBBER file won't be in that log because it isn't part of the client.mk checkout. Even if it is, it would be HEAD and not test_unit, right?

Comment 9

[Rob Campbell [:rc] (:robcee)]

gavin: I added mozilla/tools/tinderbox-configs to the .mozconfig files so they're getting checked out now and will show up in the cvsco.log. So yes, you're missing something!

(still debugging this, I think there's some path munging going on because the rmdir line isn't finding c:\\slave\\trunk\\mozilla\\objdir on winxp)

Comment 10

[Rob Campbell [:rc] (:robcee)]

cvs commit: Examining .
Checking in killAndClobberWin.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/unittest/killAndClobberWin.py,v  <--  killAndClobberWin.py
new revision: 1.2; previous revision: 1.1
done
Checking in mozconfig;
/cvsroot/mozilla/tools/buildbot-configs/testing/unittest/mozconfig,v  <--  mozconfig
new revision: 1.2; previous revision: 1.1
done
Checking in mozconfig-win2k3;
/cvsroot/mozilla/tools/buildbot-configs/testing/unittest/mozconfig-win2k3,v  <--  mozconfig-win2k3
new revision: 1.2; previous revision: 1.1
done
Checking in mozconfig-winxp;
/cvsroot/mozilla/tools/buildbot-configs/testing/unittest/mozconfig-winxp,v  <--  mozconfig-winxp
new revision: 1.2; previous revision: 1.1
done

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Oh, sorry, I skimmed over that part of the patch because I thought it was unrelated :(

It's still using HEAD instead of test_unit though, right? I guess that's not a big deal...

Comment 12

[Rob Campbell [:rc] (:robcee)]

yeah, still head. We should probably start sticking clobber files in tools/buildbot-configs/testing/unittest though that would be a different bug...

Comment 13

[(not currently active) Ted Mielczarek]

Mass move of Core:Testing bugs to mozilla.org:ReleaseEngineering. Filter on RelEngMassMove to ignore.