388232 - Restricting a bug to a group sets reporter_accessible and cc_accessible to 0

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

This is a regression due to bug 388045:

When you restrict a bug to some group, both the reporter_accessible and cc_accessible attributes are automatically set to 0, as shown by the bug activity table:

 CC Accessible           1      0
 Reporter Accessible     1      0
 Group                          security

The reason is because process_bug.cgi doesn't make sure that these fields are defined first. When the bug is not restricted, these checkboxes are not displayed, and so set_foo_accessible() assumes their value to be 0.

Comment 1

[Max Kanat-Alexander]

Of course process_bug doesn't check if the fields are defined. They're checkboxes. So if they're defined, they're 0.

I think what really needs to happen is that the reporter_accessible and cclist_accessible changes need to just be moved before the group changes, which should be easy.

Comment 2

[Max Kanat-Alexander]

Okay, wait. This check already happens before bugs have groups. So I'll have to investigate.

Oh, also:
(In reply to comment #1)
> So if they're defined, they're 0.

  s/defined/not defined/

Comment 3

[Max Kanat-Alexander]

Attachment: v1

Okay, this fixes it. It's also a much more sensible function that $bug->groups(), currently. Eventually we should also have a groups_chooseable() function, and just eliminate $bug->groups.

Comment 4

[Frédéric Buclin]

Comment on attachment 272420 [details] [diff] [review]
v1

r=LpSolit

Comment 5

[Max Kanat-Alexander]

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.379; previous revision: 1.378
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.193; previous revision: 1.192
done