388297 - Increased memory leak when deleting a bookmark (and more?)

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Steve England [:stevee]]

1. New profile, start firefox with leaklogging enabled.
2. Close Firefox, then restart it with leak logging enabled (so bug 385045 doesn't pollute the report)
3. Right click on the 'Getting Started' bookmark on the bookmarks toolbar.
4. Choose delete.
5. Close firefox
6. Analyse Log

Small leakage with:
- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a7pre) Gecko/2007070401 Minefield/3.0a7pre

Leaked outer window 18c2590 at address 18c2590.
Leaked inner window 1bbb998 (outer 1ba3ca8) at address 1bbb998.
 ... with URI "about:blank".
Leaked inner window 1149f70 (outer 18c2590) at address 1149f70.
 ... with URI "about:blank".
Leaked outer window 1ba3ca8 at address 1ba3ca8.
Summary:
Leaked 4 out of 7 DOM Windows
Leaked 0 out of 38 documents
Leaked 0 out of 3 docshells

Increased leakage with:
- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a7pre) Gecko/2007070504 Minefield/3.0a7pre

Leaked outer window 27bd668 at address 27bd668.
Leaked inner window 1bbde38 (outer 1ba3c38) at address 1bbde38.
 ... with URI "about:blank".
Leaked outer window 1ba3c38 at address 1ba3c38.
Leaked outer window 18c40b8 at address 18c40b8.
Leaked inner window 28ecc78 (outer 27bd668) at address 28ecc78.
 ... with URI "http://www.mozilla.org/projects/minefield/".
Leaked inner window 114a3b0 (outer 18c40b8) at address 114a3b0.
 ... with URI "about:blank".
Leaked document at address 1ea7040.
 ... with URI "chrome://global/content/bindings/tabbrowser.xml".
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/tabbrowser.xml".
Leaked document at address 26f8e80.
 ... with URI "chrome://global/content/platformHTMLBindings.xml".
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/platformHTMLBindings.xml".
Leaked document at address 1eca4c8.
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/browser.jar!/content/brow
ser/places/toolbar.xml".
 ... with URI "chrome://browser/content/places/toolbar.xml".
Leaked document at address 27bf6e8.
 ... with URI "chrome://global/content/bindings/findbar.xml".
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/findbar.xml".
Leaked document at address 1e65118.
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/browser.jar!/content/brow
ser/places/menu.xml".
 ... with URI "chrome://browser/content/places/menu.xml".
Leaked document at address 1eb7598.
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/button.xml".
 ... with URI "chrome://global/content/bindings/button.xml".
Leaked document at address 1dd7008.
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/browser.jar!/content/brow
ser/urlbarBindings.xml".
 ... with URI "chrome://browser/content/urlbarBindings.xml".
Leaked document at address 1de0008.
 ... with URI "chrome://global/content/bindings/general.xml".
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/general.xml".
Leaked document at address 1e05348.
 ... with URI "chrome://global/content/bindings/tree.xml".
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/tree.xml".
Leaked document at address 1e524f8.
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/splitter.xml".
 ... with URI "chrome://global/content/bindings/splitter.xml".
Leaked document at address 1ebf0a0.
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/toolbarbutton.xml".
 ... with URI "chrome://global/content/bindings/toolbarbutton.xml".
Leaked document at address 2758668.
 ... with URI "chrome://global/content/bindings/notification.xml".
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/notification.xml".
Leaked document at address 1c2e008.
Leaked document at address 1e37190.
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/menu.xml".
 ... with URI "chrome://global/content/bindings/menu.xml".
Leaked document at address 1e096a8.
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/stringbundle.xml".
 ... with URI "chrome://global/content/bindings/stringbundle.xml".
Leaked document at address 1eb3008.
 ... with URI "chrome://global/skin/globalBindings.xml".
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/classic.jar!/skin/classic
/global/globalBindings.xml".
Leaked document at address 27f6bd0.
 ... with URI "chrome://global/content/bindings/progressmeter.xml".
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/progressmeter.xml".
Leaked document at address 279e010.
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/browser.xml".
 ... with URI "chrome://global/content/bindings/browser.xml".
Leaked document at address 26b7fc8.
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/tabbox.xml".
 ... with URI "chrome://global/content/bindings/tabbox.xml".
Leaked document at address 26dc318.
 ... with URI "chrome://global/content/bindings/textbox.xml".
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/textbox.xml".
Leaked document at address 28a6498.
 ... with URI "http://www.mozilla.org/projects/minefield/".
Leaked document at address 1e06f40.
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/autocomplete.xml".
 ... with URI "chrome://global/content/bindings/autocomplete.xml".
Leaked document at address 1e4bc38.
 ... with URI "chrome://global/content/bindings/toolbar.xml".
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/toolbar.xml".
Leaked document at address 1dd5920.
 ... with URI "chrome://global/content/bindings/popup.xml".
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/popup.xml".
Leaked document at address 1dd2fc8.
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/text.xml".
 ... with URI "chrome://global/content/bindings/text.xml".
Leaked document at address 2738fb8.
 ... with URI "chrome://browser/content/search/search.xml".
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/browser.jar!/content/brow
ser/search/search.xml".
Leaked document at address 26be398.
 ... with URI "jar:file:///C:/Documents%20and%20Settings/Ste/Desktop/firefox-3.0
a7pre.en-US.win32%2005-Jul-2007%2004-57/firefox/chrome/toolkit.jar!/content/glob
al/bindings/scrollbox.xml".
 ... with URI "chrome://global/content/bindings/scrollbox.xml".
Summary:
Leaked 6 out of 7 DOM Windows
Leaked 27 out of 38 documents
Leaked 0 out of 3 docshells

Checkins to module PhoenixTinderbox between 2007-07-04 00:00 and 2007-07-05 05:00:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-07-04+00&maxdate=2007-07-05+05&cvsroot=%2Fcvsroot

However, if you replace step 4 with "Choose Properties, then click 'cancel' in the bookmark properties dialog" the same leakage is reported, so the summary of this bug probably need improved. Could this be bug 296474 showing itself, but now instead of only leaking when you choose to customize toolbars, it's now leaking on bookmark manipulation also? (Which, i guess, is a kind of customization of the toolbars)

Comment 1

[Boris Zbarsky [:bzbarsky]]

At a guess, I would think this is more likely due to the popup changes, given that checkin range.  Not sure whether or how, though.

Comment 2

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007100905 Minefield/3.0a9pre ID:2007100905

Since beltzner just marked this blocking I decided to retest and can no longer get leak-gauge.pl to report any leakage when I follow my str in comment 0 - so removing the blocking‑firefox3+ flag and marking WORKSFORME.

If someone else could verify, that'd be great.

Comment 3

[Jesse Ruderman]

I saw something leak, but I guess that's covered by bug 337190.