oflabel not localizable in file wizardManager.properties

VERIFIED FIXED in M18

Status

()

Core
Localization
P3
normal
VERIFIED FIXED
19 years ago
18 years ago

People

(Reporter: Allan Masri, Assigned: Alec Flett)

Tracking

Trunk
x86
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta2-])

(Reporter)

Description

19 years ago
in file /chrome/global/locale/wizardManager.properies, the statement, 
oflabel=of, is not sufficient for localization. It should be part of a formatted 
string that includes other elements with which it will be concatenated.

Comment 1

19 years ago
Allan, can you find out who owns this file? Reassign it to the owner and ask for 
the explanation. We should report the concatenation in a sentence as bugs.
(Reporter)

Comment 2

19 years ago
This variable also appears in file, 
/profile/resources/locale/en-US/createProfileWizard.properties
Assignee: rchen → alecf
(Assignee)

Comment 3

19 years ago
yeah, this is me, but I think someone in i18n needs to explain to me how to do
this. How do I do a formatted string in JS?
(Reporter)

Comment 4

19 years ago
Other properties files just use the %ld, %s, %ud, etc. in the proper location in 
the string. See 
http://lxr.mozilla.org/seamonkey/source/mailnews/mime/resources/mime.properties 
for examples. They seem to follow C string formatting rules. 
(Assignee)

Comment 5

19 years ago
I know that, what I need is a JavaScript function that will format this stuff
for me (i.e. exposing PR_smprintf or the like from JS)
(Reporter)

Comment 6

19 years ago
Bill Law wrote a function that does this for 
http://lxr.mozilla.org/seamonkey/source/xpfe/components/xfer/resources/downloadP
rogress.js
(Assignee)

Comment 7

19 years ago
ok, but bill is insane.
before tague left, he said he was going to expose this from JS. I'm going to see 
if I can track it down myself.

Comment 8

19 years ago
cc bobj and ftang.

Updated

18 years ago
Blocks: 12394
Keywords: nsbeta2

Comment 9

18 years ago
[nsbeta2+]
Whiteboard: [nsbeta2+]

Comment 10

18 years ago
whoops, operator error, should be nsbeta2-
Whiteboard: [nsbeta2+] → [nsbeta2-]

Comment 11

18 years ago
marking M18.
Target Milestone: --- → M18
(Assignee)

Comment 12

18 years ago
we have a method now of formatting strings from JS so this should be an easy
fix.
Status: NEW → ASSIGNED
Keywords: nsbeta3
(Assignee)

Comment 13

18 years ago
Fix in hand.
(Assignee)

Comment 14

18 years ago
fix went in a few days ago
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 15

18 years ago
oh no, wait. I just checked that fix in now (it's been in my tree for a few
days)

Comment 16

18 years ago
I verified this in 2000-09-19-05 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.