Closed
Bug 388356
Opened 17 years ago
Closed 17 years ago
nsXULPopupManager.h:124: warning: ‘DirectionFromKeyCode_lr_tb’ defined but not used
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Unassigned)
Details
Attachments
(1 file)
|
2.69 KB,
patch
|
enndeakin
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
The problem is that there are two arrays that are declared as being 'static' in a header file. This is generally incorrect and wastes space. I'm attaching a trivial patch make these 'extern' in the header file, and to define them in only one compilation unit.
Attachment #272552 -
Flags: superreview?(jst)
Attachment #272552 -
Flags: review?(enndeakin)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 272552 [details] [diff] [review] Fix warnings Looks good
Attachment #272552 -
Flags: review?(enndeakin) → review+
|
||
Updated•17 years ago
|
Attachment #272552 -
Flags: superreview?(jst) → superreview+
|
Reporter | |
Comment 2•17 years ago
|
||
Fix checked into trunk.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•