388380 - [pango] font selection for generic fonts needs to depend on language

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The font selection for generic fonts doesn't seem to depend on the author-specified language.  I think this is a problem for CJK text, and a regression from Firefox 2.0.

Steps to reproduce:
 1. load the attached testcase
 2. compare the characters in the 2 rows

Actual results: Characters are the same across rows.

Expected results:
  - Bottom part of first character has different shape
  - Second character has 1 dot above in top row, 2 in bottom
  - Third character has a hook at the top of the right stroke in the bottom row only
  - Fourth character has an additional parallel line in the bottom row
  - Fifth character has a hook at the top-left in the bottom row only

This may or may not be a problem on machines where the font prefs are set to something other than their defaults.  The defaults are just "serif" and "sans-serif".

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: testcase

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

no, generic font should be depend on language, e.g., the western fonts should be used in CJK paragraph if there are western characters.

But your suggestion is an actual problem for it. I think that it is a best way that the CJK fonts should be changed the order in generic alias fonts if it is possible.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #2)
> no, generic font should be depend on language,

generic alias fonts should *not* depend on language,

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

er, I might misunderstand a spec of fontconfig, it seems that the generic alias families should be defined for each languages. (I read http://www.spinics.net/lists/font-config/msg00854.html , thanks Oshima-san.)

if so, I should rewrite the code for resolving generic alias family.

Comment 5

[Stuart Parmenter]

does this still happen after 362682 landed?

Comment 6

[Stuart Parmenter]

we send the language now so this should be fixed.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

It seems that this is fixed by bug 362682 on my environment. But not sure why it fixed this.

The generic font names are resolved to actual fonts at initializing the gfxPangoFontGroup, however, they are not used language information then, see |gfxFontconfigUtils::ResolveFontName|.