38848 - nsIPluginManager::GetValue is not implemented

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[stanley.ho]

In modules\plugin\nglsrc\nsPluginHostImpl.cpp, nsIPluginManager::GetValue is 
not implemented. The Solaris OJI plug-in relies on the method call

    nsIPluginManager::GetValue(nsPluginManagerVariable_XDisplay, &display) 

to obtain back the X display that the browser is using. Without this method, 
the Solaris OJI plug-in cannot work at all because it has to be reparent its 
applet window onto the browser.

Comment 1

[edburns]

Stanley is correct.  This is indeed not implemented.

Comment 2

[drapeau]

Nominating for beta 2: if this is not fixed, there can be no Java Plug-In for X
Window System environments (e.g., Linux, Solaris, HP-UX, AIX, etc.).

Perhaps a fix for this can be found by digging through old 4.X browser code? 
Perhaps the Netscape engineers have access to this?

Comment 3

[Phil Peterson]

[nsbeta2+]

Comment 4

[rusty.lynch]

adding myself to the cc

Comment 5

[edburns]

Taking this.

Comment 6

[Christopher Blizzard (:blizzard)]

This shouldn't be too tough.  Just return GDK_DISPLAY() and it should work.

Comment 7

[edburns]

Accept

Comment 8

[edburns]

We're currently discussing the apparently incorrect specification of the 
GetValue method in nsIPluginManager.h.

Comment 9

[edburns]

Shooting for this milestone.

Comment 10

[edburns]

ETA 22 July 2000

Comment 11

[edburns]

Attachment: Fix for this bug.

Comment 12

[edburns]

This fix requires a change in the signature of nsIPluginManager::GetValue().

Here's the diff:
RCS file: /cvsroot/mozilla/modules/plugin/public/nsIPluginManager.h,v
retrieving revision 1.9
diff -u -r1.9 nsIPluginManager.h
--- nsIPluginManager.h	1999/11/06 03:32:35	1.9
+++ nsIPluginManager.h	2000/07/15 19:46:22
@@ -80,7 +80,7 @@
      * @result - NS_OK if this operation was successful
      */
     NS_IMETHOD
-    GetValue(nsPluginManagerVariable variable, void *value) = 0;
+    GetValue(nsPluginManagerVariable variable, void **value) = 0;
 
     /**
      * Causes the plugins directory to be searched again for new plugin 

I need a= and r=

Comment 13

[edburns]

Attachment: Fix for this bug, second iteration.

Comment 14

[edburns]

Thanks to Waterson's use of the new C++ casting operators, we have a solution 
that doesn't require changing the API.

Looking for approval for this solution, the second iteration.

Ed

Comment 15

[edburns]

Just checked in fix.

Comment 16

[shrirang khanzode]

verified that the fix is in.