388546 - aRuleDetail parameters to nsRuleNode::Compute*Data don't need to be references

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

These parameters are passed by reference when they could just be passed by value.  (I noticed this in the debugger while looking at bug 383979.)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(I'm tempted to use const on the parameters in the implementation, except Mozilla code very rarely uses const on parameters (const int, void *const, etc.) where the const is not part of the function signature.  We probably should, though.  I sort of wish it were the default in C++.)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 272739 [details] [diff] [review]
patch

r+sr=bzbarsky, and I have no problem with making those |const RuleDetail|.  Would be a good idea, imo.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

OK, I'll add the consts in the implementation only -- that's legal, and I think probably less confusing for those reading the header.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk.