Closed
Bug 388546
Opened 18 years ago
Closed 17 years ago
aRuleDetail parameters to nsRuleNode::Compute*Data don't need to be references
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(1 file)
|
19.71 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
These parameters are passed by reference when they could just be passed by value. (I noticed this in the debugger while looking at bug 383979.)
Attachment #272739 -
Flags: superreview?(bzbarsky)
Attachment #272739 -
Flags: review?(bzbarsky)
|
Assignee | |
Comment 1•18 years ago
|
||
(I'm tempted to use const on the parameters in the implementation, except Mozilla code very rarely uses const on parameters (const int, void *const, etc.) where the const is not part of the function signature. We probably should, though. I sort of wish it were the default in C++.)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 272739 [details] [diff] [review]
patch
r+sr=bzbarsky, and I have no problem with making those |const RuleDetail|. Would be a good idea, imo.
Attachment #272739 -
Flags: superreview?(bzbarsky)
Attachment #272739 -
Flags: superreview+
Attachment #272739 -
Flags: review?(bzbarsky)
Attachment #272739 -
Flags: review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
OK, I'll add the consts in the implementation only -- that's legal, and I think probably less confusing for those reading the header.
|
|
Assignee | |
Comment 4•17 years ago
|
||
Fix checked in to trunk.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•