CheckFontCallback needs to consider font-size:larger/smaller

RESOLVED FIXED in mozilla1.9alpha8

Status

()

Core
CSS Parsing and Computation
--
major
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({css1})

Trunk
mozilla1.9alpha8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

10 years ago
Created attachment 272744 [details]
testcase

CheckFontCallback needs to consider the 'larger' and 'smaller' values of 'font-size', which mean that the value on the element is derived from its parent.  (We set aInherited correctly in nsRuleNode::SetFont, but we need to get it right here as well so we know to get the real parentFont rather than the bogus one.)

Bug 383979 will make this show up in more cases.
(Assignee)

Comment 1

10 years ago
Created attachment 272747 [details]
testcase that only shows up with bug 383979 landed

This is probably a more likely testcase to show up in the real world.  Thus this blocks bug 383979.
(Assignee)

Comment 2

10 years ago
Created attachment 272748 [details] [diff] [review]
patch
Attachment #272748 - Flags: superreview?(bzbarsky)
Attachment #272748 - Flags: review?(bzbarsky)
Comment on attachment 272748 [details] [diff] [review]
patch

r+sr=bzbarsky.

I really wish we didn't duplicate logic like this between the check callbacks and the actual computation.  :(
Attachment #272748 - Flags: superreview?(bzbarsky)
Attachment #272748 - Flags: superreview+
Attachment #272748 - Flags: review?(bzbarsky)
Attachment #272748 - Flags: review+
(Assignee)

Comment 4

10 years ago
Fix checked in to trunk.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.