String changes for malware warning

RESOLVED WORKSFORME

Status

()

Toolkit
Safe Browsing
RESOLVED WORKSFORME
11 years ago
4 years ago

People

(Reporter: johnath, Assigned: johnath)

Tracking

Trunk
Firefox 3 alpha7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 272820 [details] [diff] [review]
String change and css tweak

We should make a couple changes to the strings in the malware error page, based on discussions with google (maintainers of the malware checking db) and legal.  Specifically:

 - The language "You should not visit this site." is arguably too strong, or at least too strong for the browser to assert.
 - The text should include a link to the page on stopbadware.org that requests a review of a wrongly listed site ( http://www.stopbadware.org/home/reviewinfo )

The attached patch adds a sentence pointing to the review site, and drops the "You should not visit this site" text.  It also adds anchor tags to the CSS style rules for malware, so that they get the same white-on-red treatment, instead of the hard-to-read blue-on-red default. 

The motivation behind dropping the last line instead of just softening the language ("You probably shouldn't visit..." "We wouldn't visit..." &c) is principally that the error page itself is already a hard stop.  The sentence was there originally as a kind of parity with the calls-to-action/suggestions made by other error pages, but now that there is appeal text, users that want to see the page have a better option anyhow - getting the site unlisted.

Beltzner's already OK'd the change, so no UI-R request here.
Attachment #272820 - Flags: review?(cbiesinger)
Attachment #272820 - Flags: review?(cbiesinger) → review+
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
Keywords: checkin-needed

Updated

11 years ago
Assignee: nobody → johnath
Status: ASSIGNED → NEW

Comment 1

11 years ago
mozilla/dom/locales/en-US/chrome/netError.dtd                1.9
mozilla/toolkit/themes/pinstripe/global/netError.css         1.5
mozilla/toolkit/themes/winstripe/global/netError.css         1.5
mozilla/browser/locales/en-US/chrome/overrides/netError.dtd  1.9
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M7

Comment 2

11 years ago
The changes to netError.dtd are more or less semantic and should change the key, see http://developer.mozilla.org/en/docs/Writing_localizable_code for reference.

stopbadware.org is *really* lagging right now, it took minutes before the server answered right now, is that OK?

Could you add a localization note, explaining what localizers are supposed to do about the link? (http://developer.mozilla.org/en/docs/Localization_notes)

This bug has a in-testcase-, but as legal and google are involved, is there anything we need to test in our localizations?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 3

10 years ago
This bug is about string changes which are now invalidated by changes made in bug 420751 (with appropriate string revs).  Resolving WORKSFORME since the strings in current trunk, well, work for me.  :)
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago10 years ago
Resolution: --- → WORKSFORME
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.