Closed
Bug 388706
Opened 19 years ago
Closed 19 years ago
Cache what font langgroup prefs resolve to
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: pavlov, Assigned: pavlov)
Details
(Keywords: perf)
Attachments
(1 file, 2 obsolete files)
|
7.60 KB,
patch
|
sharparrow1
:
review+
|
Details | Diff | Splinter Review |
right now we look up prefs every time and then process the string every time and then resolve each of those font names every time. We should just cache the results.
this should give a good speedup for anything that we have to use prefs to lookup fonts for.
|
Assignee | |
Updated•19 years ago
|
Attachment #272887 -
Flags: review?(vladimir)
Comment on attachment 272887 [details] [diff] [review]
fix
Minusing because you told me to do so.
Attachment #272887 -
Flags: review?(vladimir) → review-
|
|
Assignee | |
Updated•19 years ago
|
Flags: blocking1.9+
|
|
Assignee | |
Comment 2•19 years ago
|
||
better fix, observes for pref changes and whatnot.
Attachment #272887 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•19 years ago
|
||
Attachment #278097 -
Attachment is obsolete: true
|
||
Comment 4•19 years ago
|
||
Comment on attachment 278101 [details] [diff] [review]
now with autotarrays
r=me, assuming you add a comment about why you don't need to unregister the pref callback.
Attachment #278101 -
Flags: review+
|
|
Assignee | |
Comment 5•19 years ago
|
||
seems to have resulted in about a 20-30ms drop on talos
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•