388726 - handle RSS feed items without links

Status: RESOLVED DUPLICATE of bug 303567

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

handle RSS feed items without links

bkap has a feed and some of the items don't have links.  

for those items, they don't show up in his livemark folder.

this is still valid rss 2.0, from the spec "All elements of an item are optional, however at least one of title or description must be present."

it looks like the problem may be in http://lxr.mozilla.org/seamonkey/source/toolkit/components/places/src/nsLivemarkService.js#495

it looks like we won't call insertLivemarkChild() if there is no href.

I think we should use the site location for the rss feed, instead.  (I don't think we can insert a bookmark without a url.)

Comment 1

[Robert Sayre]

I think there is bug on this already. When I ported the livemarks service to JS, the existing code behaved this way, so I preserved the behavior.

Comment 2

[Phil Ringnalda (:philor)]

Several bugs, with a variety of suggestions (though none have ever had a suggestion that would make it clear that there's no point in clicking this bookmark, because it has a link that is not particularly related to the item).

Had I ever felt that using livemarks to read non-link feeds was a reasonable thing, I might have suggested grey-texting link-free items (hmm, how much work would it be to have disabled bookmark menu items?), but I still stand by the same thing I've typed quite a few times since 2004: "live bookmarks are not a general-purpose be-all end-all feed reader, and bookmarks without URLs aren't bookmarks."

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv