388880 - paying a price for the personal toolbar, even if it is hidden

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

paying a price (doing a query, building up results) for the personal toolbar, even if it is hidden

I found this while trying to track down some leaks for bug #387203.

need to investigate.

Comment 1

[Dietrich Ayala (:dietrich)]

maybe should only init if toolbar is visible, hook into it's load/show event?

http://mxr.mozilla.org/seamonkey/source/browser/base/content/browser.js#308

also, probably shouldn't init the places folder queries either until this happens.

Comment 2

[Marco Bonardo [:mak]]

updated link:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#446

this is still true, even if the toolbar is hidden the place property gets set and the result is populated.

Comment 3

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch

Comment 6

[Dão Gottwald [:dao]]

Bug 528884 likely introduced this bug to popups.

Comment 7

[Dão Gottwald [:dao]]

Requesting blocking since the toolbar is now hidden by default.

Comment 8

[Dão Gottwald [:dao]]

Attachment: patch

updated to tip

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/7c44f05a46ae

Comment 10

[Dão Gottwald [:dao]]

numbers from mozilla.dev.tree-management:

Txul decrease 6.08% on MacOSX 10.6.2 Firefox
Txul decrease 3.17% on MacOSX 10.5.8 Firefox
Ts decrease 4.39% on Linux Firefox