388891 - codesighs tools don't work on macos due to mishandling of nm output

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Vlad Sukhoy]

Attachment: fix

The regexp within nm perl wrapper does not match output of nm tool, there is extra whitespace in there.

Comment 1

[Vlad Sukhoy]

Turning codesighs on for macos tinderboxen once this is fixed seems to be a
good idea too.

Comment 2

[Stan Shebs]

Comment on attachment 273061 [details] [diff] [review]
fix

Looks plausible.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Checked that patch in.  Do you want to leave this for enabling it on tinderbox, or new bug?

Comment 4

[Vlad Sukhoy]

Err.. If that helps to get it enabled - sure.

Comment 5

[Vlad Sukhoy]

I mean, whatever is the best - use your judgment.

Comment 6

[Boris Zbarsky [:bzbarsky]]

OK.  Might as well use this bug, I think.

I wonder whether just flipping 0 to 1 in the two lines at http://lxr.mozilla.org/mozilla/source/tools/tinderbox-configs/firefox/macosx/tinder-config.pl#70 is enogh.  We seem to already pull and build the code (see http://lxr.mozilla.org/mozilla/source/tools/tinderbox-configs/firefox/macosx/mozconfig).

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 8

[Boris Zbarsky [:bzbarsky]]

Checked in the other patch too.  We now have a nice number on tbox.

Vlad, thanks for fixing this!

Comment 9

[Vlad Sukhoy]

codesighs can be a standalone tool too.. For those of us who have large private branches and in general to look at the binary impact of a feature or tweaking various build options.. It has to be made a little more independent from the build though. Sounds like a project idea for some future summer student - quite independent, doable within reasonable time scope, but still useful.