Closed Bug 388909 Opened 14 years ago Closed 14 years ago

disabled MOZ_RDF build broken after landing 384374

Categories

(Core Graveyard :: File Handling, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

Attachments

(2 files)

Attached patch BUILD FixSplinter Review
I think we can disable 
nsExternalHelperAppService::FillHandlerInfoForTypeFromDS

Because it never calls when RDF disabled
Attachment #273085 - Flags: superreview?(cbiesinger)
Attachment #273085 - Flags: review?(cbiesinger)
Attachment #273085 - Flags: superreview?(cbiesinger)
Attachment #273085 - Flags: superreview+
Attachment #273085 - Flags: review?(cbiesinger)
Attachment #273085 - Flags: review+
Keywords: checkin-needed
Assignee: nobody → romaxa
Flags: in-testsuite-
mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp  1.318
mozilla/uriloader/exthandler/nsExternalHelperAppService.h    1.83
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta1
:(, after fixing of 'bug 385065 – protocol handling dialog'

This was broken again
Blocks: 385065
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Keywords: checkin-needed
Sorry about that - there were some nasty conflicts when merging - didn't realize I broke this.
Once again, sorry!

Checking in uriloader/exthandler/nsExternalHelperAppService.cpp;
new revision: 1.329; previous revision: 1.328
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.