388910 - Building with disabled MOZ_XUL failed

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Build fix

After landing https://bugzilla.mozilla.org/attachment.cgi?id=260753

Building in embedding-profile=minimal configuration was broken

Comment 1

[alexander :surkov (:asurkov)]

Comment on attachment 273086 [details] [diff] [review]
Build fix


>+#ifdef MOZ_XUL
>   nsCOMPtr<nsIXULDocument> xulDoc(do_QueryInterface(mDocument));
>   if (!xulDoc) {
>     // XXX Need to invent better check to see if doc is focusable,
>     // which it should be if it is scrollable. A XUL document could be focusable.
>     // See bug 376803.
>     *aState |= nsIAccessibleStates::STATE_FOCUSABLE;
>   }
>+#endif

if there is no XUL then we should set focusable state.

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Rev2 Focusable state added

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 273233 [details] [diff] [review]
Rev2 Focusable state added

I think it's ok with me though asking Neil for sr to be sure :)

thank you for bug fixing.

Comment 4

[alexander :surkov (:asurkov)]

checked in