If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Building with disabled MOZ_XUL failed

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 273086 [details] [diff] [review]
Build fix

After landing https://bugzilla.mozilla.org/attachment.cgi?id=260753

Building in embedding-profile=minimal configuration was broken
Attachment #273086 - Flags: review?(surkov.alexander)

Comment 1

10 years ago
Comment on attachment 273086 [details] [diff] [review]
Build fix


>+#ifdef MOZ_XUL
>   nsCOMPtr<nsIXULDocument> xulDoc(do_QueryInterface(mDocument));
>   if (!xulDoc) {
>     // XXX Need to invent better check to see if doc is focusable,
>     // which it should be if it is scrollable. A XUL document could be focusable.
>     // See bug 376803.
>     *aState |= nsIAccessibleStates::STATE_FOCUSABLE;
>   }
>+#endif

if there is no XUL then we should set focusable state.
Attachment #273086 - Flags: review?(surkov.alexander) → review-

Updated

10 years ago
Assignee: aaronleventhal → romaxa
(Assignee)

Comment 2

10 years ago
Created attachment 273233 [details] [diff] [review]
Rev2 Focusable state added
Attachment #273086 - Attachment is obsolete: true
Attachment #273233 - Flags: review?(surkov.alexander)

Comment 3

10 years ago
Comment on attachment 273233 [details] [diff] [review]
Rev2 Focusable state added

I think it's ok with me though asking Neil for sr to be sure :)

thank you for bug fixing.
Attachment #273233 - Flags: superreview?(neil)
Attachment #273233 - Flags: review?(surkov.alexander)
Attachment #273233 - Flags: review+

Updated

10 years ago
Attachment #273233 - Flags: superreview?(neil) → superreview+

Comment 4

10 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.