Closed Bug 388944 Opened 13 years ago Closed 13 years ago

client.py can't produce tamarin repo URL from a ssh:// hg repo URL

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0

People

(Reporter: ted, Assigned: jorendorff)

Details

Attachments

(2 files)

jst hit this yesterday, and I did a little testing today and found out that Python's urlparse doesn't know how to handle the ssh:// url scheme used by Hg.  This means that the call to |urlparse.urljoin| doesn't produce a proper repo URL for Tamarin.  I think Hg just treats these ssh urls as if they were HTTP, so maybe we could just do a temporary s/^ssh/http/ for the purposes of the urljoin.
Status: NEW → ASSIGNED
Attached patch v1Splinter Review
Heh.  Here's a patch, but it's up to you whether all that complexity is worth it.

I will post a much simpler patch in a minute.
Assignee: nobody → jorendorff
Attachment #273116 - Flags: review?(ted.mielczarek)
Attached patch v2Splinter Review
I think I like this better.
Attachment #273117 - Flags: review?(ted.mielczarek)
Comment on attachment 273117 [details] [diff] [review]
v2

This is certainly nicer than the other patch on this bug, the only downside is that it would be nice to pull tamarin-central via ssh:// if you pulled your mozilla repo from there, but seeing as how you only have to specify the repo once, I don't think it's that big of a deal.  Please do clean up those extra imports you added when you added this code initially, though.
Attachment #273117 - Flags: review?(ted.mielczarek) → review+
Pushed to mozilla-central and actionmonkey.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Attachment #273116 - Flags: review?(ted.mielczarek)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.