These R_386_PC32 relocations creep into the build when using system headers without adding them to the list in config/system-headers. This breaks x86_64 builds (with a newer GCC), and it breaks running these builds on an SELinux system. As a stopgap until we can get an x86_64 tinderbox (bug 359336), bsmedberg suggested a unit test that would check for these sections in our shared libs. I believe it doesn't have to be any more complicated than: objdump -R *.so | grep R_386_PC32
Pretty simple, except for the ugly shell logic.
Comment on attachment 274377 [details] [diff] [review] add a simple unit test 1) Do you want to test TARGET_CPU as well? 2) you probably want to quote $$relcount in case objdump exits without any output 3) dist/bin/*.so won't check component DLLs
Attachment #274377 - Flags: review?(benjamin) → review-
12 years ago
Given taht bug 359336 is fixed, I'm WONTFIXING.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX
Component: Testing → General
Product: Core → Testing
QA Contact: testing → general
Reopening, bug 595112 apparently added a 32-bit only case of this, so we should just check it.
Assignee: ted.mielczarek → benjamin
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago → 9 years ago
Resolution: --- → FIXED
Was it intentional that the target was 'scheck' rather than 'check'?
Also, do 'make check' tests run anywhere on tinderbox? (And would this even pass until bug 604307 is fixed?)
They run after the build on both the opt and debug build machines. (Technically after the build has been uploaded for the test machines to do their thing.)
Now that bug 604307 is fixed, should this be changed from 'scheck' to 'check'?
5 years ago
That sounds reasonable, yes.
https://tbpl.mozilla.org/?tree=Try&rev=48e240000c54 with try: --build do --platform linux,android-x86,linux_gecko --unittests none --talos none --no-emails
Attachment #8334281 - Flags: review?(benjamin) → review+
You need to log in before you can comment on or make changes to this bug.