add unit test to check for R_386_PC32 relocations

RESOLVED FIXED

Status

RESOLVED FIXED
12 years ago
5 years ago

People

(Reporter: ted, Assigned: benjamin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

These R_386_PC32 relocations creep into the build when using system headers without adding them to the list in config/system-headers.  This breaks x86_64 builds (with a newer GCC), and it breaks running these builds on an SELinux system.  As a stopgap until we can get an x86_64 tinderbox (bug 359336), bsmedberg suggested a unit test that would check for these sections in our shared libs.  I believe it doesn't have to be any more complicated than:
objdump -R *.so | grep R_386_PC32
Pretty simple, except for the ugly shell logic.
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #274377 - Flags: superreview?(dbaron)
Attachment #274377 - Flags: review?(benjamin)
(Assignee)

Comment 2

12 years ago
Comment on attachment 274377 [details] [diff] [review]
add a simple unit test

1) Do you want to test TARGET_CPU as well?
2) you probably want to quote $$relcount in case objdump exits without any output
3) dist/bin/*.so won't check component DLLs
Attachment #274377 - Flags: review?(benjamin) → review-
Given taht bug 359336 is fixed, I'm WONTFIXING.

Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX
Component: Testing → General
Product: Core → Testing
QA Contact: testing → general
(Assignee)

Comment 4

9 years ago
Reopening, bug 595112 apparently added a 32-bit only case of this, so we should just check it.
Assignee: ted.mielczarek → benjamin
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
(Assignee)

Comment 5

9 years ago
http://hg.mozilla.org/mozilla-central/rev/b4811d1b1fea
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago9 years ago
Resolution: --- → FIXED
Also, do 'make check' tests run anywhere on tinderbox?  (And would this even pass until bug 604307 is fixed?)
They run after the build on both the opt and debug build machines. (Technically after the build has been uploaded for the test machines to do their thing.)
(Assignee)

Comment 10

5 years ago
That sounds reasonable, yes.
Flags: needinfo?(benjamin)
(Assignee)

Updated

5 years ago
Attachment #8334281 - Flags: review?(benjamin) → review+
You need to log in before you can comment on or make changes to this bug.