NECKO: Crash when opening a local copy of home.netscape.com

VERIFIED FIXED in M9

Status

()

Core
Networking
P1
normal
VERIFIED FIXED
19 years ago
18 years ago

People

(Reporter: Pierre Saslawsky, Assigned: Gagan)

Tracking

Trunk
PowerPC
Mac System 8.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

19 years ago
This bug seems fairly serious to me because it prevents us from replaying some
local files in order to investigate other bugs. I'm leaving the 'Assign To' field
blank but it looks like the bug should be assigned to <gagan> who worked in that
area recently.

To reproduce:
- Connect to http://home.netscape.com using Communicator and save the page source
into a local file
- Open Viewer
- Select File|Open and open the page you just saved
==> Crash

It happens because the page source has a reference through a relative path to a
file called "h.js". NetLib tries to open that file on the local machine and, of
course, fails. We have then the following:

- NET_GetURL() calls net_CallExitRoutine() on line #3175 of mkgeturl.c and
this_entry->status is equal to MK_UNABLE_TO_LOCATE_FILE.
- net_CallExitRoutine() calls bam_exit_routine() on line #1158 of mkgeturl.c
- bam_exit_routine() calls nsDocumentBindInfo::OnStopBinding() on line #1403 of
nsNetService.cpp with a status equal to NS_BINDING_FAILED.
- nsDocumentBindInfo::OnStopBinding() crashes on line #1819 of nsDocLoader.cpp
because m_NextStream was released in m_NextStream->OnStopBinding() on line #1806

Proposed solution:
------------------
It seems to me that nsDocumentBindInfo::OnStopBinding() should not call
m_NextStream->OnStopBinding() on line #1806 if the status is NS_BINDING_FAILED.
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED
(Reporter)

Updated

19 years ago
Priority: P3 → P1
Target Milestone: M4
(Reporter)

Comment 1

19 years ago
Marking P1/M4. Feel free to readjust.

Updated

19 years ago
Target Milestone: M4 → M5
(Assignee)

Updated

19 years ago
Target Milestone: M5 → M6
(Assignee)

Comment 2

19 years ago
Marking till Necko lands...
(Assignee)

Updated

19 years ago
Target Milestone: M6 → M8
(Assignee)

Comment 3

19 years ago
Per DP's suggestion marking these till M8. Though Necko lands with M7, we will
be able to verify it for M8.

Comment 4

19 years ago
I'm moving this to target M9, Necko will be enabled somewhere during late M8 or
early M9.  We will need to get on this and it cannot be postponed past the M9
milestone.

Updated

19 years ago
Component: Networking Library → Networking-Core

Comment 5

19 years ago
Changing all Networking Library/Browser bugs to Networking-Core component for
Browser.

Occasionally, Bugzilla will burp and cause Verified bugs to reopen when I do
this in a bulk change.  If this happens, I will fix. ;-)
(Assignee)

Updated

19 years ago
(Assignee)

Comment 6

19 years ago
Please check if its still valid with Necko.
(Assignee)

Updated

19 years ago
Summary: Crash when opening a local copy of home.netscape.com → NECKO: Crash when opening a local copy of home.netscape.com

Updated

19 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED

Comment 7

19 years ago
this is fixed with 7/31 necko builds

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 8

19 years ago
I guess I should mark verified then

Comment 9

18 years ago
Bulk move of all Networking-Core (to be deleted component) bugs to new
Networking component.
You need to log in before you can comment on or make changes to this bug.