389032 - Error in error console when changing scope in searching within Bookmarks Manager

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Al Billings [:abillings - ex-MoCo]]

1. Open Bookmarks Manager
2. Click in the Search box and type some text (like 'xx'), which replaces the grayed text, "Search in Bookmarks".
3. Click on "Current Collection Only" in scope dropdown

Result: The following error message in the Error Console:

Error: uncaught exception: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsINavHistoryService.executeQueries]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://browser/content/places/tree.xml :: load :: line 107"  data: no]

This was found in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707200404 Minefield/3.0a7pre.

Comment 1

[(not reading, please use [e-mail] instead)]

I see this too, and might be related to bug #389024 (but not sure yet)

from the debugger, GetSimpleBookmarksQueryFolder() is returning -1.

taking a quick look.

Comment 2

[(not reading, please use [e-mail] instead)]

we're calling query.setFolders() with [-1] in tree.xml's applyFilter()

Comment 3

[(not reading, please use [e-mail] instead)]

in places.js, we are doing:

var folderId = content.getResult().root.itemId;

http://lxr.mozilla.org/mozilla/source/browser/components/places/content/places.js#364

Not sure if this a recent regression or not.

Comment 4

[(not reading, please use [e-mail] instead)]

again, not sure if this is a recent regression, but fix in hand.

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: patch

I was worried about this being a regresson from #388378, but that change has not landed.  (But, I'll review it to make sure my patch won't regress this bug.)

Comment 6

[(not reading, please use [e-mail] instead)]

moving off to M8

Comment 7

[Asaf Romano (gone)]

Comment on attachment 273206 [details] [diff] [review]
patch

r=mano

Comment 8

[(not reading, please use [e-mail] instead)]

fixed.

/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.95; previous revision: 1.94
done

Comment 9

[Al Billings [:abillings - ex-MoCo]]

Verified in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707230404 Minefield/3.0a7pre.

I need to add a few litmus cases around the functionality of this search box. 

Comment 10

[(not reading, please use [e-mail] instead)]

al, the summary of this bug doesn't make it sound like something the end user would see (which may be why mconnor cleared it as a fx 3 blocker).  But, there were end user implications.  Can you reword the summary?

Comment 11

[Al Billings [:abillings - ex-MoCo]]

They aren't going to see the error console. The error is fixed now though.

Comment 12

[Aakash Desai [:aakashd]]

Test case https://litmus.mozilla.org/show_test.cgi?id=6765 has been updated on litmus to allow for future regression testing.

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv