389052 - Today pane: Initial view of tasks panel displays completed tasks even when 'show completed' is turned off

Status: VERIFIED FIXED

(Calendar :: Tasks, defect)

Description

[Jay Rossiter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5) Gecko/20070713 Firefox/2.0.0.5
Build Identifier: Lightning 0.7pre 2007071103 w/ Thunderbird version 2.0.0.5pre (20070720)

When initially switching to the tasks panel after an app restart completed tasks are displayed in the list even though "Show completed tasks" is disabled.

Toggling the checkbox properly hides the completed tasks

Reproducible: Always

Steps to Reproduce:
1.  Create task
2.  Mark it as complete
3.  Restart Tbird
4.  Switch to calendar view
5.  Switch to tasks tab
Actual Results:  
Completed tasks are displayed

Expected Results:  
Completed tasks should be hidden

Comment 1

[Raymond]

This is also the case in/with the "today pane" with lightning 0.7pre (build 2007073105). 
If you toggle the checkbox twice it show only the not completed tasks..

Comment 2

[Martin Schröder [:mschroeder]]

Raymond, I can't reproduce this problem. Can you give detailed steps to reproduce and results for the new layout with today pane?

Comment 3

[Jay Rossiter]

I'm (original submitter) seeing it in the Today pane as well, with no special steps.  Same reproduction as above.

Comment 4

[Pete Riley]

I also can't reproduce this in the Today Pane after I restart Thunderbird.  Can someone post example tasks that don't work correctly?

Comment 5

[Raymond]

the steps I take are really simple:
1: start thunderbird with mail view and today pane
2: thunderbird retrieves mail
3: lightning retries data from ftp server ( ics is on ftp )
4: lightning files today pane..

and then all my tasks are there (finished and unfinished) and the checkbox is unchecked..

When I was trying to reproduce the steps I had the javascript console open and I got this message:

Error: this.mStartDate has no properties
Source File: chrome://calendar/content/calendar-multiday-view.xml
Line: 2510

maybe this helps.

I'm using thunderbird 1.5.0.12 here at home..
I will try to reproduce it tomorrow at work with thunderbird 2.0.0.5..

maybe there is a difference in thunderbird.

Comment 6

[Raymond]

just tested thunderbird 2.0.0.5 with lightning 0.7pre (build 2007073105) and this error also appears in the console:

Error: this.mStartDate has no properties
Source File: chrome://calendar/content/calendar-multiday-view.xml
Line: 2510

Using the same steps as in comment 5

Comment 7

[Michael Büttner (no reviews TFN)]

Attachment: patch v1

I wasn't able to reproduce this bug, but the checkbox initiates a view refresh if we're still in mail mode and never switched to the calendar mode. So, this patch makes sure that this exception doesn't get thrown. I'm not sure if it fixes the original problem.

Comment 8

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 274748 [details] [diff] [review]
patch v1

I can reproduce this, I'm not sure why though. The patch unfortunatly doesn't fix the problem. If this patch is needed nevertheless, please attach it to a different bug. Also, add the blank between if and (

Comment 9

[Martin Schröder [:mschroeder]]

Confirming per comment#8.

Comment 10

[Ulf Stroehler]

@daniel: I'd vote for 0.7+ as especially (not only wcap) power users have tons of completed tasks; with many of them already years old.

Comment 11

[Daniel Boelzle [:dbo]]

Berend volunteered

Comment 12

[Stefan Sitter [:ssitter]]

Works for me on Windows 2000 using local storage calendar and
  Lightning 0.7pre (2007091204) with Thunderbird 1.5.0.14pre (20070910)
  Lightning 0.7pre (2007091204) with Thunderbird 2.0.0.7pre (20070912)
  Lightning 0.6a1  (2007091206) with Thunderbird 3.0a1pre (2007091203)
Maybe this was fixed by the checkin for 372830.

Jay, Raymond: I'd like you to retest this issue with your Lightning setup.

Comment 13

[Jay Rossiter]

This does appear to be working in today's build (2007091204).  It was likely fixed  at the same time the option was renamed to "Hide completed"

Comment 14

[Raymond]

It works for me on both my systems with  thunderbird 2.0.0.6 and lightning 0.7pre (build 2007091204) on windows xp

Comment 15

[Stefan Sitter [:ssitter]]

Thanks for retest. Resolving as Fixed by the checkin for Bug 372830.

Comment 16

[Andreas Treumann]

Set issue to 'verified (see comment #12, #13, and #14). I checked this issue again with lightning build 2007091204 at linux.