389112 - after Alt puts focus on menu bar, Tab and Esc don't leave menu bar

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[skierpage]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072104 Minefield/3.0a7pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072104 Minefield/3.0a7pre

I drive Firefox fast from the keyboard.  In recent Minefield nightly builds I notice my keyboard focus gets stuck in the menu bar.  Here's one way to reproduce, there may be others.

Reproducible: Always

Steps to Reproduce:
1. Press Alt (only) on Windows.  Focus jumps to menu bar, highlighting File. (Good)
2. Try moving the focus from the menu bar by pressing Tab or Esc.

I reproduced in Safe mode.

Actual Results:  
Focus doesn't leave menu bar.

Expected Results:  
The focus should leave the menu bar as it does in Windows Notepad and Thunderbird 2.

I'm not aware that I'm pressing Alt on its own; I just notice that the focus is stuck on File and my usual ways of getting off stopped working.

The workaround is to use keyboard navigation to open a menu, at which point Tab and Esc do shift the focus.  Or obviously click somewhere with the mouse.

I'm not sure if this is Minefield-only or a Toolkit issue.  (I tried downloading XULRunner nightly but devmo's myapp XUL sample doesn't have any menus.)

Comment 1

[Neil Deakin]

Attachment: indicate that the menu is closed when tab or escape is pressed

This code is necessary when a menubar is active but no menu is open.

Comment 2

[[e-mail]]

Comment on attachment 274187 [details] [diff] [review]
indicate that the menu is closed when tab or escape is pressed

I wasn't sure I could give r+sr here but bz said it was OK.

Comment 3

[skierpage]

In addition to Tab and Esc, pressing Alt a second time should also leave the menu bar (as it does in TB2).

Comment 5

[Samuel Sidler (old account; do not CC)]

Enn: comment 3 is right. Pressing alt a second time should have the same behavior as esc/tab.

Comment 6

[Neil Deakin]

Yes, I know the fix for that and will do that after bug 390589.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 274187 [details] [diff] [review]
indicate that the menu is closed when tab or escape is pressed

a1.9=dbaron

Comment 8

[Neil Deakin]

Filed bug 392314 on the Alt key bug.