389114 - Build fails with PR_LOG undefined

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Hank Mills]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/2007071823 Minefield/3.0a7pre
Build Identifier: 

Since bug Bug 358093 landed, I've been unable to build Firefox with ac_add_options --disable-logging in my mozconfig. Either removing that or commenting out the PR_LOG stuff added by the patch for Bug 358093 will allow Firefox to build.

Reproducible: Always

Comment 1

[Frank Wein [:mcsmurf]]

Can you paste the actual build error you get?

Comment 2

[Hank Mills]

/Developer/moz/mozilla/widget/src/cocoa/nsClipboard.mm
/Developer/moz/mozilla/widget/src/cocoa/nsClipboard.mm: In static member function 'static NSDictionary* nsClipboard::PasteboardDictFromTransferable(nsITransferable*)':
/Developer/moz/mozilla/widget/src/cocoa/nsClipboard.mm:302: error: 'sCocoaLog' was not declared in this scope
/Developer/moz/mozilla/widget/src/cocoa/nsClipboard.mm:302: error: 'PR_LOG_ALWAYS' was not declared in this scope
/Developer/moz/mozilla/widget/src/cocoa/nsClipboard.mm:302: warning: left-hand operand of comma has no effect
/Developer/moz/mozilla/widget/src/cocoa/nsClipboard.mm:302: error: 'PR_LOG' was not declared in this scope
make[6]: *** [nsClipboard.o] Error 1
make[5]: *** [libs] Error 2
make[4]: *** [libs] Error 2
make[3]: *** [libs_tier_gecko] Error 2
make[2]: *** [tier_gecko] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2

Comment 3

[Josh Aas]

Attachment: fix v1.0

Comment 4

[Josh Aas]

This should be blocking because it is a build failure for a not-uncommon configuration.

Comment 5

[Josh Aas]

landed on trunk