Reporter service should support non-soap based reports

VERIFIED FIXED

Status

VERIFIED FIXED
12 years ago
3 years ago

People

(Reporter: raccettura, Assigned: raccettura)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

12 years ago
Since the client side is moving away from SOAP, we need to support non soap reports.
(Assignee)

Updated

12 years ago
Blocks: 389131
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

12 years ago
Posted patch Patch v1Splinter Review
(Assignee)

Comment 2

12 years ago
As a reminder to self, turn off error reporting before checkin.
Depends on: 400563
Attachment #282878 - Flags: review?(rhelmer)
Comment on attachment 282878 [details] [diff] [review]
Patch v1

Sorry, I'm probably not the right person to review this :)
Attachment #282878 - Flags: review?(rhelmer)
(Assignee)

Comment 4

12 years ago
Who should r= on this?  Thus far I've been on my own, and Georgi did a review of the codebase earlier this year.
Comment on attachment 282878 [details] [diff] [review]
Patch v1

Mike, we really need this for the beta, if you can't review, let me know and I'll take a stab, but I think your PHP is less stale than mine... :)
Attachment #282878 - Flags: review?(morgamic)
I checked my dirty form in /tests outside htdocs.  The form is a placeholder until there's something better -- PHPUnit or SimpleTest functional tests would be cool eventually but it's not a showstopper.
Comment on attachment 282878 [details] [diff] [review]
Patch v1

Looks good.  Properly escaped and straightforward.  I don't typically use REQUEST but here it makes testing easier so WFM.  Thanks for the patch Robert!
Attachment #282878 - Flags: review?(morgamic) → review+
Btw, don't forget to set error_reporting(0) and add the $ to the service rewrite rule like we talked about:

RewriteRule ^service(/)?([A-Za-z0-9.-]+)?$ service.php?v=$2 [QSA]

instead of

RewriteRule ^service(/)?([A-Za-z0-9.-]+)? service.php?v=$2 [QSA]

(Assignee)

Updated

12 years ago
Blocks: 401816
(Assignee)

Comment 9

12 years ago
Thanks for the quick r=.  This is in cvs, so closing.

401816 is for the push.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
verified fixed - Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a9pre) Gecko/2007110103 Minefield/3.0a9pre is now able to send reports to reporter.mozilla.org
Status: RESOLVED → VERIFIED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.