389128 - Reporter service should support non-soap based reports

Status: VERIFIED FIXED

(Webtools Graveyard :: Reporter, defect)

Description

[Robert Accettura [:raccettura]]

Since the client side is moving away from SOAP, we need to support non soap reports.

Comment 1

[Robert Accettura [:raccettura]]

Attachment: Patch v1

Comment 2

[Robert Accettura [:raccettura]]

As a reminder to self, turn off error reporting before checkin.

Comment 3

[Robert Helmer [:rhelmer]]

Comment on attachment 282878 [details] [diff] [review]
Patch v1

Sorry, I'm probably not the right person to review this :)

Comment 4

[Robert Accettura [:raccettura]]

Who should r= on this?  Thus far I've been on my own, and Georgi did a review of the codebase earlier this year.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 282878 [details] [diff] [review]
Patch v1

Mike, we really need this for the beta, if you can't review, let me know and I'll take a stab, but I think your PHP is less stale than mine... :)

Comment 6

[Michael Morgan [:morgamic]]

Attachment: simple test form that can be re-used at some point

I checked my dirty form in /tests outside htdocs.  The form is a placeholder until there's something better -- PHPUnit or SimpleTest functional tests would be cool eventually but it's not a showstopper.

Comment 7

[Michael Morgan [:morgamic]]

Comment on attachment 282878 [details] [diff] [review]
Patch v1

Looks good.  Properly escaped and straightforward.  I don't typically use REQUEST but here it makes testing easier so WFM.  Thanks for the patch Robert!

Comment 8

[Michael Morgan [:morgamic]]

Btw, don't forget to set error_reporting(0) and add the $ to the service rewrite rule like we talked about:

RewriteRule ^service(/)?([A-Za-z0-9.-]+)?$ service.php?v=$2 [QSA]

instead of

RewriteRule ^service(/)?([A-Za-z0-9.-]+)? service.php?v=$2 [QSA]

Comment 9

[Robert Accettura [:raccettura]]

Thanks for the quick r=.  This is in cvs, so closing.

401816 is for the push.

Comment 10

[Carsten Book [:Tomcat]]

verified fixed - Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a9pre) Gecko/2007110103 Minefield/3.0a9pre is now able to send reports to reporter.mozilla.org