389145 - for disabled popup-type datepicker, dropmarker should look disabled

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[mcdavis941 (sporadically reading bugmail)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5) Gecko/20070713 Firefox/2.0.0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007070804 Minefield/3.0a7pre

For a popup-type datepicker, when disabled, the dropmarker is disabled as well, but it looks normal.  It should actually look disabled so that users don't think it's operable when it really isn't.

Reproducible: Always

Comment 1

[mcdavis941 (sporadically reading bugmail)]

Attachment: popup datepicker appearance when disabled

Shows popup datepicker as normal, readonly and disabled

Comment 2

[Régis Caspar]

Attachment: patch

Patch adding xbl:inherits to the dropmarker and "chrome://global/skin/dropmarker.css" to the ressources in the xbl file 
Will attach XUL testcase too

Comment 3

[Régis Caspar]

Attachment: XUL testcase

Comment 4

[Régis Caspar]

Perhaps the input box should look disabled too?

Comment 5

[mcdavis941 (sporadically reading bugmail)]

(In reply to comment #4)
> Perhaps the input box should look disabled too?
> 

Yeah, it should probably have styling similar to a disabled textbox.

Comment 6

[Adam Guthrie]

Régis, Neil Deakin (enndeakin@) could probably review this.

Comment 7

[Régis Caspar]

Comment on attachment 273295 [details] [diff] [review]
patch

(In reply to comment #6)
> Régis, Neil Deakin (enndeakin@) could probably review this.
Thanks Adam.

Comment 8

[Neil Deakin]

Comment on attachment 273295 [details] [diff] [review]
patch

Looks OK.

Inheriting readonly isn't needed though.

Comment 9

[Régis Caspar]

Thanks Neil. 
What do you think about the textbox should it be greyed or not (in your opinion) when the datepicker is disabled?

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Regis: you can use the checkin-needed keyword now, instead of the status whiteboard marker.

That being said, it looks like the minor change from comment 8 hasn't been addressed, and you probably want Neil to answer the question before this gets checked in, so removing it for now.

Comment 11

[Régis Caspar]

I wasn't aware of the keyword, thanks. 

About readonly not needed, I thought it wasn't an issue. Will make the change, sorry.

About the question in comment 9, I think the inputbox state is not part of this bug but we sure can handle its state in this bug with the popup state.

Comment 12

[Régis Caspar]

Attachment: patch 2

Patch without "readonly" inherited following Neil's comment

Comment 13

[Neil Deakin]

(In reply to comment #9)
> Thanks Neil. 
> What do you think about the textbox should it be greyed or not (in your
> opinion) when the datepicker is disabled?
> 

Quite likely should be yes. It should behave the same as the timepicker in the
windows/mac set date/time dialog. But that should be a different bug.

Comment 14

[Régis Caspar]

OK, => bug 389577 for the inputbox will attach a patch to it ASAP

-> adding [checking needed] back

Comment 15

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/content/widgets/datetimepicker.xml 	1.6