Closed Bug 389172 Opened 14 years ago Closed 14 years ago

(Bootstrap) Stage step should check out shipped-locales file before using it

Categories

(Release Engineering :: General, defect)

x86
Linux
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rhelmer, Assigned: rhelmer)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch check out shipped-locales file (obsolete) — Splinter Review
As per bug 387970 comment 12, the locale manifest file (shipped-locales) is expected by the Stage step but never actually checked out.
Attachment #273315 - Flags: review?(preed)
Assignee: build → rhelmer
Attachment #273315 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #273316 - Flags: review?(preed)
Attachment #273315 - Flags: review?(preed)
Comment on attachment 273316 [details] [diff] [review]
check out shipped-locales file with RELEASE tag (not branch tag)

Looks good; a couple of things:


>+    # check out locales manifest (shipped-locales)
>+    $this->Shell(
>+      cmd => 'cvs', 
>+      cmdArgs => [ '-d', $mozillaCvsroot, 
>+                   'co', '-d', catfile('config'), '-r', $productTag . '_RELEASE',

No need for this catfile() call here. Also, can you add a carriage return between the -d args and the -r args, for readability?
Attachment #273316 - Flags: review?(preed) → review+
Attached patch patch as landedSplinter Review
Checking in Bootstrap/Step/Stage.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Step/Stage.pm,v  <--  Stage.pm
new revision: 1.14; previous revision: 1.13
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.