Closed
Bug 389172
Opened 18 years ago
Closed 18 years ago
(Bootstrap) Stage step should check out shipped-locales file before using it
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rhelmer, Assigned: rhelmer)
References
Details
Attachments
(2 files, 1 obsolete file)
|
1.30 KB,
patch
|
preed
:
review+
|
Details | Diff | Splinter Review |
|
1.31 KB,
patch
|
Details | Diff | Splinter Review |
As per bug 387970 comment 12, the locale manifest file (shipped-locales) is expected by the Stage step but never actually checked out.
Attachment #273315 -
Flags: review?(preed)
|
Assignee | |
Comment 1•18 years ago
|
||
Assignee: build → rhelmer
Attachment #273315 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #273316 -
Flags: review?(preed)
Attachment #273315 -
Flags: review?(preed)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 273316 [details] [diff] [review]
check out shipped-locales file with RELEASE tag (not branch tag)
Looks good; a couple of things:
>+ # check out locales manifest (shipped-locales)
>+ $this->Shell(
>+ cmd => 'cvs',
>+ cmdArgs => [ '-d', $mozillaCvsroot,
>+ 'co', '-d', catfile('config'), '-r', $productTag . '_RELEASE',
No need for this catfile() call here. Also, can you add a carriage return between the -d args and the -r args, for readability?
Attachment #273316 -
Flags: review?(preed) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Checking in Bootstrap/Step/Stage.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Step/Stage.pm,v <-- Stage.pm
new revision: 1.14; previous revision: 1.13
done
|
|
Assignee | |
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•