389232 - Firefox build fails on OpenSolaris with enable-libxul

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ginn Chen]

Comment 1

[Ginn Chen]

Sorry, I clicked enter by accident, here're the description.

It fails while linking libxul.so

CC  -norunpath -xlibmil -xlibmopt -features=tmplife -lCrun -lCstd -xbuiltin=%all -features=tmplife -norunpath -mt  -DNDEBUG -DTRIMMED -xO3  -G -z muldefs -h libxul.so -o libxul.so  nsStaticXULComponents.o nsUnicharUtils.o nsCompressedCharMap.o nsBidiUtils.o nsRDFResource.o    -lpthread -M /usr/lib/ld/map.noexstk -xildoff -z lazyload -z combreloc -z ignore -L/usr/lib -L/usr/sfw/lib -R'$ORIGIN:$ORIGIN/..' -L/usr/lib/X11 -z ignore -R '$ORIGIN:$ORIGIN/..'   -z allextract ../../embedding/browser/gtk/src/libgtkembedmoz.a ../../toolkit/xre/libxulapp_s.a  ../../staticlib/components/libxpconnect.a ../../staticlib/components/libnecko.a ../../staticlib/components/libuconv.a ../../staticlib/components/libi18n.a ../../staticlib/components/libchardet.a ../../staticlib/components/libjar50.a ../../staticlib/components/libpref.a ../../staticlib/components/libcaps.a ../../staticlib/components/libhtmlpars.a ../../staticlib/components/libimglib2.a ../../stat!
 iclib/components/libgklayout.a ../../staticlib/components/libxmlextras.a ../../staticlib/components/libdocshell.a ../../staticlib/components/libembedcomponents.a ../../staticlib/components/libwebbrwsr.a ../../staticlib/components/libnsappshell.a ../../staticlib/components/libtxmgr.a ../../staticlib/components/libchrome.a ../../staticlib/components/libcommandlines.a ../../staticlib/components/libtoolkitcomps.a ../../staticlib/components/libpipboot.a ../../staticlib/components/libpipnss.a ../../staticlib/components/libgkplugin.a ../../staticlib/components/libmozfind.a ../../staticlib/components/libappcomps.a ../../staticlib/components/libxpinstall.a ../../staticlib/components/libjsd.a ../../staticlib/components/libautoconfig.a ../../staticlib/components/libauth.a ../../staticlib/components/libcookie.a ../../staticlib/components/libpermissions.a ../../staticlib/components/libuniversalchardet.a ../../staticlib/components/libcomposer.a ../../staticlib/components/librdf.a ../../s!
 taticlib/components/libwindowds.a ../../staticlib/components/l!
 ibintlap
p.a ../../staticlib/components/libfileview.a ../../staticlib/components/libstoragecomps.a ../../staticlib/components/libplaces.a ../../staticlib/components/libtkautocomplete.a ../../staticlib/components/libsatchel.a ../../staticlib/components/libpippki.a ../../staticlib/components/libucvmath.a ../../staticlib/components/libwidget_gtk2.a ../../staticlib/components/libsystem-pref.a ../../staticlib/components/libgkgfxthebes.a ../../staticlib/components/liboji.a ../../staticlib/components/libaccessibility.a ../../staticlib/components/libremoteservice.a ../../staticlib/components/libspellchecker.a ../../staticlib/libxpcom_core.a ../../staticlib/libmozreg_s.a ../../staticlib/libucvutil_s.a ../../staticlib/libgkgfx.a ../../staticlib/libgfxshared_s.a ../../staticlib/libmorkreader_s.a ../../staticlib/libgtkxtbin.a ../../staticlib/libgfxpsshar.a ../../staticlib/libthebes.a ../../staticlib/libjsj.a  -z defaultextract  -lsqlite3 -R ../../dist/bin -L../../dist/bin -L../../dist/lib -L../.!
 ./jpeg -lmozjpeg -L../../modules/libimg/png -lmozpng -L../../dist/bin -lmozjs -L../../dist/bin -L../../dist/lib -lcrmf -lsmime3 -lssl3 -lnss3 -lsoftokn3  -L../../modules/zlib/src -lmozz -lpangoxft-1.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.0   -L../../gfx/cairo/cairo/src -lmozcairo -L../../gfx/cairo/libpixman/src -lmozlibpixman   -lXrender -lfreetype -lfontconfig -L../../dist/lib -lplds4 -lplc4 -lnspr4 -L/usr/lib -L/usr/sfw/lib -L/usr/lib/X11 -lpthread -ldl -lposix4  -lX11 -lsocket  -lnsl -R/usr/openwin/lib -L/usr/openwin/lib -lXft -lfontconfig   -lgtk-x11-2.0 -latk-1.0 -lgdk-x11-2.0 -lgdk_pixbuf-2.0 -lm -lmlib -lpangocairo-1.0 -lpango-1.0 -lcairo -lgmodule-2.0 -lgobject-2.0 -lglib-2.0   -lXt -lgthread-2.0 -L/usr/sfw/lib -R/usr/sfw/lib -lfreetype -lz -lsocket -ldl -lm     
ld: fatal: library -lsqlite3: not found
ld: fatal: File processing errors. No output written to libxul.so

Comment 2

[Ginn Chen]

Attachment: patch

add LIBS_DIR before -lsqllite3

Comment 3

[Wan-Teh Chang]

Comment on attachment 273388 [details] [diff] [review]
patch

r=wtc.

I don't know this code well enough to review this with confidence, but I found
that two other makefiles do this (extensions/canvas3d/src/Makefile.in and
gfx/cairo/glitz/src/glx/Makefile.in), so I gave my review+.

Ben, could you also review this?

Comment 4

[Ginn Chen]

patch committed