389297 - mouse cursor should change when hovering over autoscroll

Status: RESOLVED DUPLICATE of bug 213726

(Toolkit :: UI Widgets, defect)

Description

[Ori Avtalion (salty-horse)]

Attachment: Experimental patch

After the big autoscroll changes in bug 242621, the cursor no longer changes shape when hovering over the autoscroll.

I'm attaching a patch that implements it.

The patch has several pending bugs:

1) Since the autoscroll is now implemented as a <popup>, the cursor shape changes when the autoscroll is active, whether the cursor hovers over it or not. (at least on GNOME, which I'm using)

2) When activating the autoscroll, the cursor will change to the shape used in the previous invocation of the autoscroll. After moving the mouse, the cursor will change to the correct shape. Perhaps this is a <popup> bug.
To test this:
a) Restart firefox.
b) Load a page and resize the viewport so that only the horizontal scroll will be active. Activate autoscroll. The cursor will remain as an arrow. Move it, and it will be changed to the ew-resize shape.
c) Resize the page so that both the horizontal and vertical scrolls are active. Activate autoscroll. The cursor will change to the ew-resize shape. Move it, and it will change to the correct "move" shape.

Comment 1

[Ori Avtalion (salty-horse)]

Attachment: fixed patch format

Comment 2

[Martijn Wargers (dead)]

Comment on attachment 273456 [details] [diff] [review]
fixed patch format

You need to ask review from someone (I just did that for you).

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

With the old implementation, the cursor was changed over the entire browser content area.  With this patch, it'll only change over the icon itself.  I think this is a minimal gain - what you really want is the same behavior as Firefox 2, which would requires getting bug 309547 fixed.

I don't think I'm a toolkit peer, so I can't review this (unless a module owner or peer ok's my review).

See also bug 213726, which this may be a duplicate of.

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #3)
> With this patch, it'll only change over the icon itself.

...at least on some very important platforms.

Comment 5

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #4)
> (In reply to comment #3)
> > With this patch, it'll only change over the icon itself.
> 
> ...at least on some very important platforms.
> 

Sorry for the bugspam, but IIRC when I tried something like this under one of the OSes, there were differences between the results I got in most of the content area vs. area outside of the circle but inside the bounding box that would contain the circle.