Closed
Bug 389308
Opened 17 years ago
Closed 17 years ago
ActionMonkey: Rename Boolean() to js_Boolean()
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(1 file)
|
1.33 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
MMgc has a "Boolean" typedef which conflicts with the Boolean constructor function in jsbool.cpp. Rename to avoid the problem. (Should other constructors change?)
Attachment #273476 -
Flags: review?(jorendorff)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 273476 [details] [diff] [review]
v1
Yep, looks good.
Attachment #273476 -
Flags: review?(jorendorff) → review+
|
|
||
Comment 2•17 years ago
|
||
(The "Boolean" typedef is in some Mac-specific header included from MMgc, in case you're wondering.)
|
Assignee | |
Comment 3•17 years ago
|
||
Pushed to hg/actionmonkey
changeset 3580: c443e6f5bfa4
(In reply to comment #2)
> (The "Boolean" typedef is in some Mac-specific header included from MMgc, in
> case you're wondering.)
To be specific, this happens when you #include "MMgc.h" ->
/System/Library/Frameworks/CoreServices.framework/Headers/../Frameworks/CarbonCore.framework/Headers/MacTypes.h:288: error: previous declaration of 'typedef unsigned char Boolean'
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•