389313 - summarize_time.cgi needs some cleanup

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

Attachment: patch, v1

... a lot of cleanup even, see the patch. This removes many hacks, makes the code much more readable, use bug objects and will easily allow the addition of new information, e.g. bug 286452 which no longer requires to edit the .cgi script, but only to edit the template.

I tested it on both MySQL 5.0 and PostgreSQL 8.2.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1.1

SELECT * -> SELECT 1
bug_status -> get_status()

No other changes.

Comment 2

[Frédéric Buclin]

Attachment: tiny backport for 3.0, v1

This backport for 3.0 only fixes a real bug. The bug status is always in english.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 273622 [details] [diff] [review]
tiny backport for 3.0, v1

Make sure that you don't use the summary as the checkin comment, on 3.0. (That is, write an actual descriptive checkin comment.)

Comment 4

[Max Kanat-Alexander]

Comment on attachment 273619 [details] [diff] [review]
patch, v1.1

This tests out just fine. It's a huge cleanup--I didn't review each line in depth, but I tested it and I looked it over generally, and it seems just fine.

Comment 5

[Frédéric Buclin]

tip:

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.388; previous revision: 1.387
done
Checking in summarize_time.cgi;
/cvsroot/mozilla/webtools/bugzilla/summarize_time.cgi,v  <--  summarize_time.cgi
new revision: 1.22; previous revision: 1.21
done
Checking in template/en/default/bug/summarize-time.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/summarize-time.html.tmpl,v  <--  summarize-time.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.231; previous revision: 1.230
done


3.0.1:

Checking in template/en/default/bug/summarize-time.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/summarize-time.html.tmpl,v  <--  summarize-time.html.tmpl
new revision: 1.8.2.1; previous revision: 1.8
done