389351 - Spell-checking underlines can extend outside contenteditable element

Status: REOPENED

(Core :: Spelling checker, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, I can see the dotted underline from the spellchecker outside the contenteditable element.
It seems to me that spellchecking should stop when the contenteditable boundaries of the element have been reached.

Comment 1

[Wayne Mery (:wsmwk)]

Martijn, do you still see this?  I think I don't see what you are describing

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a3pre) Gecko/20100305 Minefield/3.7a3pre (.NET CLR 3.5.30729)

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.2pre) Gecko/20100302 Lanikai/3.1b1

Comment 2

[Martijn Wargers (dead)]

It can still happen, it's just that the testcase doesn't show it anymore. That might be a new bug, in itself.

Comment 3

[qw3n]

This problem shows up on the HTML5 showcase website.  http://html5demos.com/contenteditable  If you click into the contenteditable area the text above it shows spelling errors.

Comment 4

[(no longer active)]

(In reply to comment #3)
> This problem shows up on the HTML5 showcase website. 
> http://html5demos.com/contenteditable  If you click into the contenteditable
> area the text above it shows spelling errors.

This test case is not valid, since it has this code:

addEvent(editable, 'focus', function () {
  document.designMode = 'on';
});

Which puts the document inside design mode when you focus the editable area, which causes ContentEditable to be highlighted as an invalid word.

Comment 5

[qw3n]

(In reply to comment #4)
> (In reply to comment #3)
> > This problem shows up on the HTML5 showcase website. 
> > http://html5demos.com/contenteditable  If you click into the contenteditable
> > area the text above it shows spelling errors.
> 
> This test case is not valid, since it has this code:
> 
> addEvent(editable, 'focus', function () {
>   document.designMode = 'on';
> });
> 
> Which puts the document inside design mode when you focus the editable area,
> which causes ContentEditable to be highlighted as an invalid word.

Thanks did not notice that. I tried to recreate the error on my own and could not http://qw3n.com/bugzilla/editSpell.php.

Comment 6

[(no longer active)]

OK.  Please reopen if you can reproduce.  Thanks!

Comment 7

[Martijn Wargers (dead)]

New steps to reproduce:
- Load testcase
- Click on the start of the contenteditable div, before the 'f' in 'fire'.
- Press the spacebar key
- Click outside the contenteditable div.

Comment 8

[(no longer active)]

Right.  Comment 7 has a valid STR.

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

I can still repro this per comment #7, and I wonder whether this is related to editor module. Masayuki, do you have some idea?

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that it's because TextServiceDocument works with block elements like here.