Closed
Bug 389370
Opened 17 years ago
Closed 16 years ago
JavaScript stack frames through DumpJSStack are usually one line off
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 418491
People
(Reporter: WeirdAl, Unassigned)
Details
Attachments
(1 file)
40.08 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Flags: in-testsuite?
Flags: blocking1.9?
Reporter | ||
Updated•17 years ago
|
Attachment #273550 -
Attachment is patch: true
Attachment #273550 -
Attachment mime type: text/x-patch → text/plain
Reporter | ||
Comment 1•17 years ago
|
||
Sorry, I filed this before I could detail it. For many months now, I've noticed the line number for JS-based components in a stack trace from DumpJSStack() is usually off by one. Where DumpJSStack() will report line 57, the line in question is really line 58. I've tracked it as far as js_PCToLineNumber(), observing script->lineno == 50, which is a comment line (|// nsIProperty|). This bug may be closely related to bug 194828, based on my reading of that bug. Steps to reproduce: (1) Apply this patch to a trunk XULRunner source tree. (2) ac_add_options --enable-application=psycho, --enable-debug (3) make -f client.mk build (4) dist/bin/xulrunner dist/bin/application.ini (5) Wait five seconds; it will automatically crash. (6) (gdb) frame 4 (7) (gdb) call DumpJSStack() Expected results: Frame 1 says nsJSPropertyBag.js:58 Actual results: Frame 1 says nsJSPropertyBag.js:57
Reporter | ||
Comment 2•17 years ago
|
||
Note: It correctly reports the line number for the psycho.xul file.
Comment 4•17 years ago
|
||
Does comment #2 mean we can actually mark this WFM?
Reporter | ||
Comment 5•17 years ago
|
||
No, there's a difference between the line numbering for a chrome file and for a component file. The chrome file line numbering is correct, but the component file isn't. At least, that was the state of affairs when I reported this bug...
Updated•17 years ago
|
Flags: blocking1.9-
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Updated•16 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•