Status

()

Toolkit
XUL Widgets
RESOLVED FIXED
11 years ago
7 years ago

People

(Reporter: Neil Deakin, Assigned: Neil Deakin)

Tracking

unspecified
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.16 KB, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
The <menu> element is missing an open property for checking and modifying menu open state.

Several reasons for this:
 - make this consistent with button/toolbarbutton/menulist/etc.
 - make the popup documentation easier
 - removes the need to call the MenuBoxObject directly to do this
 - makes some menu/popup tests I have simpler.
(Assignee)

Comment 1

11 years ago
Created attachment 273621 [details] [diff] [review]
patch
Attachment #273621 - Flags: review?(neil)

Comment 2

11 years ago
Comment on attachment 273621 [details] [diff] [review]
patch

Why would the instanceof fail? (menulist.xml unconditionally QI's)
(Assignee)

Comment 3

11 years ago
Created attachment 273784 [details] [diff] [review]
change

We can do that too. I originally copied this code from button.xml which used instanceof.
Attachment #273621 - Attachment is obsolete: true
Attachment #273784 - Flags: review?(neil)
Attachment #273621 - Flags: review?(neil)

Comment 4

11 years ago
Comment on attachment 273784 [details] [diff] [review]
change

>+          this.boxObject.QueryInterface(Components.interfaces.nsIMenuBoxObject).
>+            openMenu(val);
Nit: prefer . at the start rather than at the end, and .s aligned, i.e.
this.boxObject.QueryInterface(Components.interfaces.nsIMenuBoxObject)
    .openMenu(val);
Attachment #273784 - Flags: review?(neil) → review+
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Flags: in-testsuite?
(Assignee)

Updated

7 years ago
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.