The <menu> element is missing an open property for checking and modifying menu open state. Several reasons for this: - make this consistent with button/toolbarbutton/menulist/etc. - make the popup documentation easier - removes the need to call the MenuBoxObject directly to do this - makes some menu/popup tests I have simpler.
Comment on attachment 273621 [details] [diff] [review] patch Why would the instanceof fail? (menulist.xml unconditionally QI's)
Created attachment 273784 [details] [diff] [review] change We can do that too. I originally copied this code from button.xml which used instanceof.
Comment on attachment 273784 [details] [diff] [review] change >+ this.boxObject.QueryInterface(Components.interfaces.nsIMenuBoxObject). >+ openMenu(val); Nit: prefer . at the start rather than at the end, and .s aligned, i.e. this.boxObject.QueryInterface(Components.interfaces.nsIMenuBoxObject) .openMenu(val);
Attachment #273784 - Flags: review?(neil) → review+
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.