Closed Bug 389429 Opened 15 years ago Closed 15 years ago

open property for <menu>

Categories

(Toolkit :: XUL Widgets, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: enndeakin, Assigned: enndeakin)

Details

Attachments

(1 file, 1 obsolete file)

The <menu> element is missing an open property for checking and modifying menu open state.

Several reasons for this:
 - make this consistent with button/toolbarbutton/menulist/etc.
 - make the popup documentation easier
 - removes the need to call the MenuBoxObject directly to do this
 - makes some menu/popup tests I have simpler.
Attached patch patch (obsolete) — Splinter Review
Attachment #273621 - Flags: review?(neil)
Comment on attachment 273621 [details] [diff] [review]
patch

Why would the instanceof fail? (menulist.xml unconditionally QI's)
Attached patch changeSplinter Review
We can do that too. I originally copied this code from button.xml which used instanceof.
Attachment #273621 - Attachment is obsolete: true
Attachment #273784 - Flags: review?(neil)
Attachment #273621 - Flags: review?(neil)
Comment on attachment 273784 [details] [diff] [review]
change

>+          this.boxObject.QueryInterface(Components.interfaces.nsIMenuBoxObject).
>+            openMenu(val);
Nit: prefer . at the start rather than at the end, and .s aligned, i.e.
this.boxObject.QueryInterface(Components.interfaces.nsIMenuBoxObject)
    .openMenu(val);
Attachment #273784 - Flags: review?(neil) → review+
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.