389501 - fetch malware data with the url classifier

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Dave Camp (:dcamp)]

This patch adds a malware warden that keeps the goog-malware-sha128 table up to date.

Comment 1

[Dave Camp (:dcamp)]

Attachment: v1

apparently I didn't attach this.

Comment 2

[Tony Chang (Google)]

Comment on attachment 274549 [details] [diff] [review]
v1

In shutdown, you need to remove the pref observers or we leak as browser windows close.  dbaron added this in bug 386665.

r+ with that change.

Comment 3

[Dave Camp (:dcamp)]

Attachment: v2

This removes the prefs observers in shutdown.

I also changed the pref's default to 'true', so I'm re-requesting review.

Comment 4

[Dave Camp (:dcamp)]

Checking in browser/app/profile/firefox.js;
/cvsroot/mozilla/browser/app/profile/firefox.js,v  <--  firefox.js
new revision: 1.193; previous revision: 1.192
done
Checking in browser/components/safebrowsing/content/application.js;
/cvsroot/mozilla/browser/components/safebrowsing/content/application.js,v  <--  application.js
new revision: 1.13; previous revision: 1.12
done
RCS file: /cvsroot/mozilla/browser/components/safebrowsing/content/malware-warden.js,v
done
Checking in browser/components/safebrowsing/content/malware-warden.js;
/cvsroot/mozilla/browser/components/safebrowsing/content/malware-warden.js,v  <--  malware-warden.js
initial revision: 1.1
done
Checking in browser/components/safebrowsing/content/sb-loader.js;
/cvsroot/mozilla/browser/components/safebrowsing/content/sb-loader.js,v  <--  sb-loader.js
new revision: 1.21; previous revision: 1.20
done
Checking in browser/components/safebrowsing/src/nsSafebrowsingApplication.js;
/cvsroot/mozilla/browser/components/safebrowsing/src/nsSafebrowsingApplication.js,v  <--  nsSafebrowsingApplication.js
new revision: 1.9; previous revision: 1.8
done
Checking in toolkit/components/url-classifier/content/listmanager.js;
/cvsroot/mozilla/toolkit/components/url-classifier/content/listmanager.js,v  <--  listmanager.js
new revision: 1.22; previous revision: 1.21
done