fetch malware data with the url classifier

RESOLVED FIXED

Status

()

Toolkit
Safe Browsing
RESOLVED FIXED
11 years ago
4 years ago

People

(Reporter: dcamp, Assigned: dcamp)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2
10.17 KB, patch
Tony Chang (Google)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
This patch adds a malware warden that keeps the goog-malware-sha128 table up to date.
OS: Mac OS X → All
Hardware: PC → All
Version: unspecified → Trunk
(Assignee)

Comment 1

11 years ago
Created attachment 274549 [details] [diff] [review]
v1

apparently I didn't attach this.
Attachment #274549 - Flags: review?(tony)
Attachment #274549 - Attachment is patch: true
Attachment #274549 - Attachment mime type: application/octet-stream → text/plain

Comment 2

11 years ago
Comment on attachment 274549 [details] [diff] [review]
v1

In shutdown, you need to remove the pref observers or we leak as browser windows close.  dbaron added this in bug 386665.

r+ with that change.
Attachment #274549 - Flags: review?(tony) → review+
(Assignee)

Comment 3

11 years ago
Created attachment 275924 [details] [diff] [review]
v2

This removes the prefs observers in shutdown.

I also changed the pref's default to 'true', so I'm re-requesting review.
Attachment #274549 - Attachment is obsolete: true
Attachment #275924 - Flags: review?(tony)

Updated

11 years ago
Attachment #275924 - Flags: review?(tony) → review+
(Assignee)

Comment 4

11 years ago
Checking in browser/app/profile/firefox.js;
/cvsroot/mozilla/browser/app/profile/firefox.js,v  <--  firefox.js
new revision: 1.193; previous revision: 1.192
done
Checking in browser/components/safebrowsing/content/application.js;
/cvsroot/mozilla/browser/components/safebrowsing/content/application.js,v  <--  application.js
new revision: 1.13; previous revision: 1.12
done
RCS file: /cvsroot/mozilla/browser/components/safebrowsing/content/malware-warden.js,v
done
Checking in browser/components/safebrowsing/content/malware-warden.js;
/cvsroot/mozilla/browser/components/safebrowsing/content/malware-warden.js,v  <--  malware-warden.js
initial revision: 1.1
done
Checking in browser/components/safebrowsing/content/sb-loader.js;
/cvsroot/mozilla/browser/components/safebrowsing/content/sb-loader.js,v  <--  sb-loader.js
new revision: 1.21; previous revision: 1.20
done
Checking in browser/components/safebrowsing/src/nsSafebrowsingApplication.js;
/cvsroot/mozilla/browser/components/safebrowsing/src/nsSafebrowsingApplication.js,v  <--  nsSafebrowsingApplication.js
new revision: 1.9; previous revision: 1.8
done
Checking in toolkit/components/url-classifier/content/listmanager.js;
/cvsroot/mozilla/toolkit/components/url-classifier/content/listmanager.js,v  <--  listmanager.js
new revision: 1.22; previous revision: 1.21
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Attachment #275924 - Attachment is patch: true
Attachment #275924 - Attachment mime type: application/octet-stream → text/plain

Updated

11 years ago
Blocks: 384941
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.