Last Comment Bug 389517 - CSV export gives resolution and status in English
: CSV export gives resolution and status in English
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Query/Bug List (show other bugs)
: 3.0
: All All
: -- minor (vote)
: Bugzilla 3.0
Assigned To: Emmanuel Seyman
: default-qa
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-07-25 01:39 PDT by Yann
Modified: 2007-07-26 09:04 PDT (History)
1 user (show)
LpSolit: approval+
LpSolit: approval3.0+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch to the 2.22 branch (854 bytes, patch)
2007-07-26 01:23 PDT, Emmanuel Seyman
no flags Details | Diff | Splinter Review
Patch to the 3.0 branch (850 bytes, patch)
2007-07-26 01:24 PDT, Emmanuel Seyman
LpSolit: review+
Details | Diff | Splinter Review
Patch to the CVS tip (853 bytes, patch)
2007-07-26 01:24 PDT, Emmanuel Seyman
LpSolit: review+
Details | Diff | Splinter Review

Description Yann 2007-07-25 01:39:09 PDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5) Gecko/20070713 Firefox/2.0.0.5
Build Identifier: 

When changing the label of status and resolution in field-descs.tmp.html, the HTMLbuglist is displaying the new labels, while the CSV buglist is displaying the DB labels.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Comment 1 Yann 2007-07-25 02:35:57 PDT
My fix:
Add: [% PROCESS "global/field-descs.none.tmpl" %]

      [% IF column == "opendate" OR column == "changeddate" %]
        [% rawcolumn = column.replace("date", "time") %]
        [% bug.$column = date.format(bug.$rawcolumn, "%Y-%m-%d %H:%M:%S") %]
      [% ELSIF column == 'bug_status' %]
        [% bug.$column = status_descs.${bug.$column} %]
      [% ELSIF column == 'resolution' %]
        [%- bug.$column = get_resolution(bug.$column) %]
      [% END %]
Comment 2 Emmanuel Seyman 2007-07-25 02:38:42 PDT
This affects 2.22 as well (well, tip of the 2.22 branch in any case).
Comment 3 Frédéric Buclin 2007-07-25 05:45:40 PDT
Yann, attach a patch if you want it implemented.
Comment 4 Emmanuel Seyman 2007-07-25 05:49:45 PDT
Taking
Comment 5 Emmanuel Seyman 2007-07-26 01:12:10 PDT
Taking, I said
Comment 6 Emmanuel Seyman 2007-07-26 01:23:33 PDT
Created attachment 273936 [details] [diff] [review]
Patch to the 2.22 branch
Comment 7 Emmanuel Seyman 2007-07-26 01:24:03 PDT
Created attachment 273937 [details] [diff] [review]
Patch to the 3.0 branch
Comment 8 Emmanuel Seyman 2007-07-26 01:24:26 PDT
Created attachment 273938 [details] [diff] [review]
Patch to the CVS tip
Comment 9 Frédéric Buclin 2007-07-26 02:52:58 PDT
Comment on attachment 273938 [details] [diff] [review]
Patch to the CVS tip

> [% PROCESS global/variables.none.tmpl %]
>+[% PROCESS "global/field-descs.none.tmpl" %]

FYI, field-descs.none.tmpl automatically calls variables.none.tmpl, so you only can remove the call to variables.none.tmpl here.
Comment 10 Frédéric Buclin 2007-07-26 08:48:58 PDT
Comment on attachment 273938 [details] [diff] [review]
Patch to the CVS tip

> [% PROCESS global/variables.none.tmpl %]
>+[% PROCESS "global/field-descs.none.tmpl" %]

Remove [% PROCESS global/variables.none.tmpl %] on checkin. r=LpSolit
Comment 11 Frédéric Buclin 2007-07-26 08:51:17 PDT
Comment on attachment 273936 [details] [diff] [review]
Patch to the 2.22 branch

2.22 is restricted to security bugs only.
Comment 12 Frédéric Buclin 2007-07-26 08:57:52 PDT
Comment on attachment 273937 [details] [diff] [review]
Patch to the 3.0 branch

> [% PROCESS global/variables.none.tmpl %]
>+[% PROCESS "global/field-descs.none.tmpl" %]

Same comment as above, [% PROCESS global/variables.none.tmpl %] can go away. r=LpSolit
Comment 13 Frédéric Buclin 2007-07-26 09:04:09 PDT
tip:

Checking in template/en/default/list/list.csv.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.csv.tmpl,v  <--  list.csv.tmpl
new revision: 1.6; previous revision: 1.5
done

3.0:

Checking in template/en/default/list/list.csv.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.csv.tmpl,v  <--  list.csv.tmpl
new revision: 1.5.4.1; previous revision: 1.5
done

Note You need to log in before you can comment on or make changes to this bug.