389531 - [he] AccountWizard.xul should show the address in LTR

Status: RESOLVED WONTFIX

(Mozilla Localizations :: he / Hebrew, defect)

Description

[Tomer Cohen :tomer]

Attachment: Hebrew locale AccountWizard.xul - current state

In Hebrew Thunderbird, we got the Account Wizard to show the email address reversed. 

In English it is [textarea - username] [label - @domain.ext], while for RTL it become [label - @domain.ext] [textarea - username]. I'm attaching screenshots and my current work toward fixing it.

Comment 1

[Tomer Cohen :tomer]

Attachment: Hebrew locale AccountWizard.xul - fixed for rtl

Attached two screenshots to describe the problem. 

By changing the order of the elements I was able to create a workaround for the problem. (See above for LXR reference) 

121           <row>
122             <hbox align="center">
123               <label class="awIdentityLabel" id="emailFieldLabel" value="&emailLabel.label;"
124                      accesskey="&emailLabel.accesskey;" control="email"/>
125               <textbox wsm_persist="true" mailtype="identity" name="email" id="email" flex="6" class="uri-element"/>
126               <label id="postEmailText"/>
127             </hbox>
128           </row>

My current workaround (will break for non-RTL builds):

121           <row>
122             <hbox align="center">
123               <label class="awIdentityLabel" id="emailFieldLabel" value="&emailLabel.label;"
124                      accesskey="&emailLabel.accesskey;" control="email"/>
126               <label id="postEmailText"/>
125               <textbox wsm_persist="true" mailtype="identity" name="email" id="email" flex="6" class="uri-element"/>
127             </hbox>
128           </row>


The question is - how do I manage to fix it in intl.css? I can't find a way to do it with floats.

Comment 2

[Tomer Cohen :tomer]

Axel, can you help us with this? 

Comment 3

[Axel Hecht [:Pike]]

I would think you want a selector for hbox and set it's direction. The selector is going to look awkward, I guess. I'd add a document selector, http://developer.mozilla.org/en/docs/CSS:@-moz-document, and then

#identitypage > vbox > grid > rows > row > hbox

might work. Untested.

Comment 4

[Eddy Nigg (StartCom)]

Attachment: Proposed patch for fixing this bug.

That was the best solution I came up with. Show by default the LTR row and collapses RTL. CSS for Hebrew reverses that...

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 280336 [details] [diff] [review]
Proposed patch for fixing this bug.

Clearing approval and review flag. Eddy, you'd need to land the mailnews changes as part of a mailnews bug. I'm not sure that that's required, though.

Neil might have a better solution in http://groups.google.com/group/mozilla.dev.tech.xul/browse_frm/thread/99b59ef1f8a54fb9/482a36f9bb272622#482a36f9bb272622.

Comment 6

[Eddy Nigg (StartCom)]

The problem with this specific row is, that a simple LTR or RTL can't be applied. The field order isn't the same as in LTR. Obviously that's the first thing I thought of. This hack is the only way I got it working, except if there is a way to numerate the fields and assign the order somehow? Or this must be taken care of at a different level perhaps. The problem is the textbox @ gmail.com fields, which must remain the same as in LTR, whereas the label leading the other fields must remain first (from the right side, i.e. RTL).

Comment 7

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).

Comment 8

[Francesco Lodolo [:flod]]

Assuming this is either fixed at this point, or a WONTFIX. In case, feel free to reopen a bug in the Thunderbird product.