Closed
Bug 389547
Opened 17 years ago
Closed 13 years ago
use .selectedIndex instead of setAttribute("selectedIndex", ...)
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bugzilla, Assigned: crussell)
Details
Attachments
(1 file)
2.20 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
in https://bugzilla.mozilla.org/show_bug.cgi?id=389525 it says it's better to use .selectedindex than setattr so perhaps this place should be changed: http://lxr.mozilla.org/mozilla/source/extensions/inspector/resources/content/viewers/domNode/domNode.js#165 http://lxr.mozilla.org/mozilla/source/extensions/inspector/resources/content/viewers/domNode/domNode.js#173 http://lxr.mozilla.org/mozilla/source/extensions/inspector/resources/content/viewers/dom/FindDialog.js#131
Updated•17 years ago
|
Summary: use .selectedIndex instead of setAttribute("selectedIndex" → use .selectedIndex instead of setAttribute("selectedIndex", ...)
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → Sevenspade
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #536803 -
Flags: review?(neil)
Comment 2•13 years ago
|
||
Comment on attachment 536803 [details] [diff] [review] replace them > // Remove the control attribute from the old panel. > deck.selectedPanel.removeAttribute("control"); Might it make sense to set the property here too?
Attachment #536803 -
Flags: review?(neil) → review+
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to comment #2) > > // Remove the control attribute from the old panel. > > deck.selectedPanel.removeAttribute("control"); > Might it make sense to set the property here too? I didn't do that, because the control setter doesn't remove the attribute when you set it to the empty string, and I wanted to keep the original behavior of removing the attribute instead of leaving them lying around. Pushed: http://hg.mozilla.org/dom-inspector/rev/edd57eef41d6
Severity: normal → trivial
Status: NEW → RESOLVED
Closed: 13 years ago
OS: Windows XP → All
Hardware: x86 → All
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•