389547 - use .selectedIndex instead of setAttribute("selectedIndex", ...)

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Henrik Gemal]

in https://bugzilla.mozilla.org/show_bug.cgi?id=389525 it says it's better to use .selectedindex than setattr

so perhaps this place should be changed:
http://lxr.mozilla.org/mozilla/source/extensions/inspector/resources/content/viewers/domNode/domNode.js#165
http://lxr.mozilla.org/mozilla/source/extensions/inspector/resources/content/viewers/domNode/domNode.js#173
http://lxr.mozilla.org/mozilla/source/extensions/inspector/resources/content/viewers/dom/FindDialog.js#131

Comment 1

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: replace them

Comment 2

[[e-mail]]

Comment on attachment 536803 [details] [diff] [review]
replace them

>     // Remove the control attribute from the old panel.
>     deck.selectedPanel.removeAttribute("control");
Might it make sense to set the property here too?

Comment 3

[Colby Russell :crussell (no longer Mozilla-ing)]

(In reply to comment #2)
> >     // Remove the control attribute from the old panel.
> >     deck.selectedPanel.removeAttribute("control");
> Might it make sense to set the property here too?

I didn't do that, because the control setter doesn't remove the attribute when you set it to the empty string, and I wanted to keep the original behavior of removing the attribute instead of leaving them lying around.

Pushed: http://hg.mozilla.org/dom-inspector/rev/edd57eef41d6