use .selectedIndex instead of setAttribute("selectedIndex", ...)

RESOLVED FIXED

Status

Other Applications
DOM Inspector
--
trivial
RESOLVED FIXED
11 years ago
7 years ago

People

(Reporter: Henrik Gemal, Assigned: crussell)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Updated

11 years ago
Summary: use .selectedIndex instead of setAttribute("selectedIndex" → use .selectedIndex instead of setAttribute("selectedIndex", ...)
Assignee: nobody → Sevenspade
Created attachment 536803 [details] [diff] [review]
replace them
Attachment #536803 - Flags: review?(neil)

Comment 2

7 years ago
Comment on attachment 536803 [details] [diff] [review]
replace them

>     // Remove the control attribute from the old panel.
>     deck.selectedPanel.removeAttribute("control");
Might it make sense to set the property here too?
Attachment #536803 - Flags: review?(neil) → review+
(In reply to comment #2)
> >     // Remove the control attribute from the old panel.
> >     deck.selectedPanel.removeAttribute("control");
> Might it make sense to set the property here too?

I didn't do that, because the control setter doesn't remove the attribute when you set it to the empty string, and I wanted to keep the original behavior of removing the attribute instead of leaving them lying around.

Pushed: http://hg.mozilla.org/dom-inspector/rev/edd57eef41d6
Severity: normal → trivial
Status: NEW → RESOLVED
Last Resolved: 7 years ago
OS: Windows XP → All
Hardware: x86 → All
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.