389565 - Remove nsIExternalProtocolService::LoadUrl

Status: RESOLVED FIXED

(Firefox :: File Handling, defect)

Description

[Shawn Wilsher :sdwilsh]

It's been depreciated for some time (just not marked in the idl as such).  We should be using LoadURI instead.

Comment 1

[Jonathan Steele]

Attachment: patch v1

I only rename loadUrl to loadURI under toolkit and browser, it should be very safe.

Comment 2

[Masatoshi Kimura [:emk]]

Shamelessly stealing.

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Bug 389565 - Remove nsIExternalProtocolService::LoadUrl.

Review commit: https://reviewboard.mozilla.org/r/165218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165218/

Comment 4

[:Paolo Amadini]

Comment on attachment 8894145 [details]
Bug 389565 - Remove nsIExternalProtocolService::LoadUrl.

https://reviewboard.mozilla.org/r/165218/#review170706

Looks simple enough, but please ensure you've tested at least one of these code paths manually.

Since some of them are fallback paths, you can test for example by forcing an exception in the main code path.

Comment 5

[Masatoshi Kimura [:emk]]

Comment on attachment 8894145 [details]
Bug 389565 - Remove nsIExternalProtocolService::LoadUrl.

https://reviewboard.mozilla.org/r/165218/#review170706

I sent a WM_APPCOMMAND | APPCOMMAND_SEND_MAIL Windows message. It will generate am "AppCommand" event, then call HandleAppCommandEvent() event listener with "SendMail" command, then call MailIntegration.sendLinkForBrowser, then call MailIntegration.sendMessage, then generate a mailto: URL and call MailIntegration._launchExternalUrl() with the mailto: URL, then call nsIExternalProtocolService.loadURI() with the URL. It worked with or without this patch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b08f3cac11a
Remove nsIExternalProtocolService::LoadUrl. r=Paolo

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9b08f3cac11a